Google Git
Sign in
chromium / infra / infra / 97ee9cecaac4d99be09278169f987e61b8116672
commit97ee9cecaac4d99be09278169f987e61b8116672[log] [tgz]
authorKevin Chowski <chowski@google.com>Thu Apr 01 18:56:27 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 01 18:56:27 2021
tree2e8a2b7bd014a62ecda307c09230fb2bf0e0c0ad
parent9c6764f5570693597642a025b73b231a7306b905 [diff]
Pinpoint: introduce fakelegacy-based smoke test.

The test relies on using a local infra dev environment to compile the
gRPC server, CLI, and fakelegacy service. The fakelegacy and gRPC
service are started, with the latter pointing at the former, and each
flow executes the CLI and inspects the output.

The fakelegacy server only supports getting, listing, and starting jobs,
so those flows are tested here.

Output inspection on the CLI is a bit rough since it's human-readable,
mostly unstructured output. In the future, if the CLI gains a -json flag
or some other more structured output format, this code can be revisited
for the better.

Change-Id: I8bf8b13b24d244855f065b5e6613e5058f0b222a
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2794926
Commit-Queue: Kevin Chowski <chowski@google.com>
Reviewed-by: Dean Berris <dberris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#39845}
5 files changed
tree: 2e8a2b7bd014a62ecda307c09230fb2bf0e0c0ad
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications.
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.