commit | 986ffe005c730dbdbd55bf3a1d9b7fc05b691c39 | [log] [tgz] |
---|---|---|
author | arthursonzogni <arthursonzogni@chromium.org> | Fri May 18 07:37:27 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri May 18 07:37:27 2018 |
tree | 27b361e819d6a5a081e3aef1c28653fad55eadbc | |
parent | 56307e33072f7e5c51861c4073e82c1f447b52bd [diff] |
FirstMeaningfulPaint: Ensure event is sent. The FirstMeaningfulPaintDetector method |CheckNetworkStable| is called whenever an active connection is removed. If the number of connection is low enough and is stable for long enough, the FirstMeaningfulPaint event will be sent. The current implementation does nothing if the document has not been parsed yet. In particular, for the main resource, this function is called when the load is completed. When it happens, the document may not have been parsed yet. It depends on how things are scheduled in blink. If there are no other sub resources to load, |CheckNetworkStable()| will not be called again and the FirstMeaningfulPaint will never be send. I am working on https://crbug.com/831155. It modifies how things are scheduled in Blink. Several tests related to this issue are failing: * SessionRestorePageLoadMetricsBrowserTest.LoadingAfterSessionRestore * SessionRestorePageLoadMetricsBrowserTest.MultipleSessionRestores * SessionRestorePageLoadMetricsBrowserTest.MultipleTabsSessionRestore * SessionRestorePageLoadMetricsBrowserTest.RestoreForeignTab This CL fixes this issue by calling |CheckNetworkStable()| when the document has been parsed. Bug: 831155 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I22c814280087dffd99e2eb6c02918dc1b8201fea Reviewed-on: https://chromium-review.googlesource.com/1064055 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#559829}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .