commit | 9875e180e5fd1b4096ca48f9386680f0bda6f709 | [log] [tgz] |
---|---|---|
author | John Budorick <jbudorick@chromium.org> | Wed Dec 05 22:57:31 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 05 22:57:31 2018 |
tree | 893343800a116772478ebc581267af77f45f893a | |
parent | 19238fc343b2404d13550dfe30d99708e1df7716 [diff] |
subprocess2: cache the string-escape codec at load time. This is a speculative fix for subprocess being unable to find string-escape later in execution; the theory being that something (unclear what) is interfering w/ codecs' lookup logic and that calling lookup earlier would allow string-escape to be cached before any such interference. See crbug.com/912292#c2 for more. Bug: 912292 Change-Id: I0abdd394253c9a4984db7c6c81d044087edc68fd Reviewed-on: https://chromium-review.googlesource.com/c/1363753 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.