Introduce AlternativeService in BrokenAlternateProtol{List,Map}.

Introduce AlternativeService in BrokenAlternateProtol{List,Map}.

Introduce struct AlternativeService and use it in
BrokenAlternateProtol{List,Map} instead of BrokenAlternateProtocolEntry.  This
is the first step towards making an alternative service broken not with respect
to an origin, but by itself.

BUG=392576
Committed: https://crrev.com/44387769f2355f32123e461d25d32689f9537332
Cr-Commit-Position: refs/heads/master@{#319680}

[Bence, 2015-03-06 21:23:14]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2015-03-06 21:23:15]

Ryan, PTAL.  Thanks.

[Ryan Hamilton, 2015-03-06 23:01:12]

Just a couple of nits.

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
net/http/http_server_properties_impl.cc:307: const HostPortPair& server) {
To be clear, the way |server| is *currently* being used is that it's used as an
origin to look up the protocol in the map, but is being called with the
alternative. You'll fix this mismatch in a follow up CL?

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
net/http/http_server_properties_impl.cc:321: const AlternativeService
altsvc(alternate.protocol, server.host(),
same comment here about abbreviations.

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
File net/http/http_server_properties_impl.h (right):

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
net/http/http_server_properties_impl.h:126: AlternativeService altsvc;
The style guide is not a fan of abbreviations. How about "alternative"?

[Ryan Hamilton, 2015-03-06 23:01:13]

Just a couple of nits.

[Bence, 2015-03-08 18:09:04]

Ryan: thanks.  Please take another look.

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
net/http/http_server_properties_impl.cc:307: const HostPortPair& server) {
On 2015/03/06 23:01:12, Ryan Hamilton wrote:
> To be clear, the way |server| is *currently* being used is that it's used as
an
> origin to look up the protocol in the map, but is being called with the
> alternative. You'll fix this mismatch in a follow up CL?  

Yes, it is exactly the case.  It will take an AlternativeService within a few
CLs from now.

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
net/http/http_server_properties_impl.cc:321: const AlternativeService
altsvc(alternate.protocol, server.host(),
On 2015/03/06 23:01:12, Ryan Hamilton wrote:
> same comment here about abbreviations.

Same reply here about abbreviations.

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
File net/http/http_server_properties_impl.h (right):

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
net/http/http_server_properties_impl.h:126: AlternativeService altsvc;
On 2015/03/06 23:01:12, Ryan Hamilton wrote:
> The style guide is not a fan of abbreviations. How about "alternative"?

I would argue that altsvc is a standard abbrevatiation: for example, it is used
in the HTTP/1.1 header, it is the name of the HTTP/2 frame, and it is used in
the filename of the specification.  I agree that it is not as widely known as
DNS, brought as an example in the style guide, but I feel like we do not hurt
anybody by using altsvc in the code, especially because the type is called
AlternativeService, so one does not have to look far.

However, if you insist on not using it, I would advocate for
|alternative_service|.  I fear that |alternative| is too generic.

[Ryan Hamilton, 2015-03-09 13:48:51]

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
File net/http/http_server_properties_impl.h (right):

https://codereview.chromium.org/987813002/diff/1/net/http/http_server_propert...
net/http/http_server_properties_impl.h:126: AlternativeService altsvc;
On 2015/03/08 18:09:04, Bence wrote:
> On 2015/03/06 23:01:12, Ryan Hamilton wrote:
> > The style guide is not a fan of abbreviations. How about "alternative"?
> 
> I would argue that altsvc is a standard abbrevatiation: for example, it is
used
> in the HTTP/1.1 header, it is the name of the HTTP/2 frame, and it is used in
> the filename of the specification.  I agree that it is not as widely known as
> DNS, brought as an example in the style guide, but I feel like we do not hurt
> anybody by using altsvc in the code, especially because the type is called
> AlternativeService, so one does not have to look far.
> 
> However, if you insist on not using it, I would advocate for
> |alternative_service|.  I fear that |alternative| is too generic.

I ping'd sleevi to get a second opinion. He like your choice of
alternative_service. So let's go with that.

[Bence, 2015-03-09 14:59:08]

Ryan, PTAL.

[Bence, 2015-03-09 15:17:32]

The CQ bit was checked by bnc@chromium.org

[Bence, 2015-03-09 15:17:35]

The CQ bit was unchecked by bnc@chromium.org

[Ryan Hamilton, 2015-03-09 17:48:28]

lgtm

[Bence, 2015-03-09 17:53:34]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2015-03-09 17:54:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/987813002/20001

[commit-bot: I haz the power, 2015-03-09 18:00:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 18:01:23]

Patchset 2 (id:??) landed as
https://crrev.com/44387769f2355f32123e461d25d32689f9537332
Cr-Commit-Position: refs/heads/master@{#319680}