commit | 987acccd410ebbea7b321f37a55713665c570166 | [log] [tgz] |
---|---|---|
author | Scott Lee <ddoman@chromium.org> | Thu Nov 26 02:37:19 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Nov 26 02:37:19 2020 |
tree | 5d4cc28229c7749a29c92b021a94a786b4d89522 | |
parent | cbdc88499500b9df6767c9900a206b38d5409f94 [diff] |
[result_adapter]: remove lucictx.ResultSink lucictx.ResultDB is - what the creator of the Invocation sets, and - consumed by `rdb stream`. lucictx.ResultSink is - what `rdb stream` sets, and - consumed by test binaries. crrev.com/c/2537416 should have removed lucictx.ResultSink. Tested with hello_resultsink.py locally. : https://paste.googleplex.com/5889123916185600 Bug: 1148141 Change-Id: Ia16c5326753e2015c51fd637761e4fbb161d8856 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2561565 Reviewed-by: Chan Li <chanli@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#36734}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.