commit | 98a7e803523c25d355e3b62907fef55dbaba3a3b | [log] [tgz] |
---|---|---|
author | Samuel Huang <huangs@chromium.org> | Tue Feb 12 15:32:22 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 12 15:32:22 2019 |
tree | bb292aea351bb216211b6d41f01cbf944b28a8d6 | |
parent | b1f865dac505908b74686004714692e192d913c4 [diff] |
[Metrics] Fix box drawing on Windows, and refactor code. The Unicode box drawing turn out malformed on Windows (even with fix_encoding.py). This CL refactors the box drawing code, and makes Windows box drawing use regular ASCII characters. Details: * Add print_red_boxed_text() to programatically print box aroun given list og strings. * Unicode box drawing characters are escaped, removing the use of non-ASCII characters in source code. * Convert message source to generators for greater flexibilty, and remove the need for manual horizontal padding. * Add proper use colorama with Style.BRIGNT and Style.RESET_ALL. * For Windows, revert to ASCII characters for box drawing. Change-Id: I71a728db480709b4376d538aaecd701f9197e7ac Reviewed-on: https://chromium-review.googlesource.com/c/1461249 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.