commit | 98d49376a8fa7f03e07aa2c6a3ee202b6214db54 | [log] [tgz] |
---|---|---|
author | Derek Cheng <imcheng@chromium.org> | Wed Jul 25 19:29:37 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jul 25 19:29:37 2018 |
tree | 5046d74fb9eeac44e3161fbad8082503a16376bb | |
parent | 3590556720bcac18e1f95ad80ee55c6770be51de [diff] |
Revert "[MacViews] Hook Web Content Textfield Touch Bar Support" This reverts commit f9da90b4c8ed7a7cc823c9bc3012658ca187b393. Reason for revert: Broke Mac10.11 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28261 Test failures: BrowserWindowTouchBarControllerTest.SearchEngineChanges BrowserWindowTouchBarControllerTest.DestroyNotificationBridge BrowserWindowTouchBarControllerTest.TabChanges Original change's description: > [MacViews] Hook Web Content Textfield Touch Bar Support > > Remove Cocoa dependency from WebTextfieldTouchBar by moving > it from TabContentsController to BrowserWindowTouchBarController. > > Hook up BrowserWindowTouchBarController to > AutofillPopupControllerImplMac on MacViews so that the > credit card touch bar can be updated. > > Move the the logic that listens to WebContent changes to the > BrowserWindowTouchBarController. When the WebContents has > changed, BrowserWindowTouchBarController will update the > WebContents in BrowserWindowDefaultTouchBar and > WebTextfieldTouchBarController. > > Modified SuggestedTextTouchBarController so that when its > WebContents has changed, it'll observe the new WebContents. > > Bug: 856391 > Change-Id: I9c29a371a0b38eb608bf8e32521abe22d5c664e0 > Reviewed-on: https://chromium-review.googlesource.com/1135829 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Sarah Chan <spqchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577940} TBR=avi@chromium.org,spqchan@chromium.org Change-Id: Ifffb93394919b40f05942eebbc3e87c07c69d7d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856391 Reviewed-on: https://chromium-review.googlesource.com/1150248 Reviewed-by: Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578015}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .