Add IsAlternativeServiceBroken(), remove is_broken.

Add IsAlternativeServiceBroken(), remove is_broken.

Add HttpServerProperties::IsAlternativeServiceBroken(), remove
AlternateProtocolInfo.is_broken.  An alternative service can be broken by
itself, not with respect to an origin.

Patch Set 1 of this CL has been manually landed at https://crrev.com/995013004
and then reverted at https://crrev.com/999893002.

BUG=392576
R=rch@chromium.org

Committed: https://crrev.com/9825fc06585af7bf868804a13e9064975d4ec374
Cr-Commit-Position: refs/heads/master@{#320189}

Committed: https://crrev.com/8445b3008c2f3d67290a64d9d1f0f5b924e5a6d6
Cr-Commit-Position: refs/heads/master@{#320428}

[Bence, 2015-03-11 21:53:47]

Ryan, PTAL.  Thanks.

[Ryan Hamilton, 2015-03-11 22:07:25]

On 2015/03/11 21:53:47, Bence wrote:
> Ryan, PTAL.  Thanks.

Instead of uploading a new CL, you could also re-open the previous CL. This is
nice because the history does not get lost. That being said, this LGTM.

[Bence, 2015-03-11 22:13:13]

The CQ bit was checked by bnc@chromium.org

[Bence, 2015-03-11 22:13:24]

On 2015/03/11 22:07:25, Ryan Hamilton wrote:
> On 2015/03/11 21:53:47, Bence wrote:
> > Ryan, PTAL.  Thanks.
> 
> Instead of uploading a new CL, you could also re-open the previous CL. This is
> nice because the history does not get lost. That being said, this LGTM.

Haven't thought about that.  Thanks.

[commit-bot: I haz the power, 2015-03-11 22:13:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/997953003/20001

[commit-bot: I haz the power, 2015-03-12 00:13:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-12 00:14:30]

Patchset 2 (id:??) landed as
https://crrev.com/9825fc06585af7bf868804a13e9064975d4ec374
Cr-Commit-Position: refs/heads/master@{#320189}

[Bence, 2015-03-12 18:20:50]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1003923002/ by bnc@chromium.org.

The reason for reverting is: Crash!

BUG=466706.

[Bence, 2015-03-12 21:07:04]

Ryan, PTAL.  Thanks.

[Ryan Hamilton, 2015-03-12 22:49:05]

LGTM, assuming that the test failed with the old version of this CL. (And with
one nit)

https://codereview.chromium.org/997953003/diff/60001/net/http/http_server_pro...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/997953003/diff/60001/net/http/http_server_pro...
net/http/http_server_properties_impl.cc:394:
ignore_result(broken_alternative_services_.erase(alternative_service));
As long as you're here, can you remove ignore_result()

[Bence, 2015-03-12 22:53:23]

The CQ bit was checked by bnc@chromium.org

[Bence, 2015-03-12 22:53:23]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/997953003/#ps80001 (title:
"Remove ignore_result.")

[commit-bot: I haz the power, 2015-03-12 22:53:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/997953003/80001

[Bence, 2015-03-12 22:54:11]

Thank you.  Yes, test has crashed, see Patch Set 3 trybot results.

https://codereview.chromium.org/997953003/diff/60001/net/http/http_server_pro...
File net/http/http_server_properties_impl.cc (right):

https://codereview.chromium.org/997953003/diff/60001/net/http/http_server_pro...
net/http/http_server_properties_impl.cc:394:
ignore_result(broken_alternative_services_.erase(alternative_service));
On 2015/03/12 22:49:05, Ryan Hamilton wrote:
> As long as you're here, can you remove ignore_result()

Done.

[Ryan Hamilton, 2015-03-12 22:54:21]

patch set 5 lgtm, too

[commit-bot: I haz the power, 2015-03-13 01:57:24]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-13 01:58:17]

Patchset 5 (id:??) landed as
https://crrev.com/8445b3008c2f3d67290a64d9d1f0f5b924e5a6d6
Cr-Commit-Position: refs/heads/master@{#320428}