commit | 99fe071354e3b3f176ee345bc98328e96d6c1fd1 | [log] [tgz] |
---|---|---|
author | Edward Lemur <ehmaldonado@chromium.org> | Wed May 15 22:37:21 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed May 15 22:37:21 2019 |
tree | ded25a206c82f39ae1be37d64e52e7074db20408 | |
parent | abe8aefc62afaebf4c10947aac622fcd86a3e9d7 [diff] |
Reland "bot_update: Pass target-ref to gclient." This is a reland of f61af56950276661d14c5c3387a706692487ecab crrev.com/c/1592577 should fix the issues with the original change. Original change's description: > bot_update: Pass target-ref to gclient. > > Bug: 956807 > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: skia > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: build > Change-Id: I4d786d989446b8c1e3f39ef78c3c99cfe70808c0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1588502 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Bug: 956807 Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: skia Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: build Change-Id: I16c22cb6aeb8e9dc1f55d77b1f12987720da3480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1613341 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.