commit | 9af53747bc71a3b8e183da795182bdf20e06817e | [log] [tgz] |
---|---|---|
author | Vaclav Brozek <vabr@chromium.org> | Wed Feb 28 15:47:32 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 28 15:47:32 2018 |
tree | c7a50abcbea66f02c2fab936954d9269fce32543 | |
parent | 23cce52102b1725a91a6e7041a6dd60b0c23c181 [diff] |
[Android]: Pass serialised passwords from native as a byte array Chrome passwords settings on Android allow the user to export passwords. The Java settings code asks the C++ code to serialise and send over the passwords. The serialised result is in UTF-8 within C++ but gets converted into UTF-16 for Java and then back to UTF-8 on writing to a cache file. This CL changes the data type from String to byte array on Java side. This eliminates the converstion to UTF-16 and back. Note 1: This was pointed out in https://chromium-review.googlesource.com/c/chromium/src/+/926527/2/chrome/browser/android/password_ui_view_android.cc#222. Note 2: This might get further simplified if https://crbug.com/817293 gets implemented, but that's not happening in M66. Bug: 788701 Change-Id: I0799b2c5f6d7e43e9b7449322d300fb9e9d82c54 Reviewed-on: https://chromium-review.googlesource.com/940226 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539832}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .