commit | 9b05d17a1c9eb9e66b07f152aebc47971f289f8b | [log] [tgz] |
---|---|---|
author | Eric Foo <efoo@chromium.org> | Thu Mar 25 21:29:58 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 25 21:29:58 2021 |
tree | d369b9b207b0e5c1b536815665ff311925dcb971 | |
parent | 6f29b99fc12eb48f1800d2c20803ac0ea94d17a2 [diff] |
Set code inclusion PRESUBMIT to True to block submission unless exempted or using // nocheck Bug: 1177609 Change-Id: I3991fb8eb1d21f24a9fbbb98d83914a766062cad Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2787449 Commit-Queue: Eric Foo <efoo@chromium.org> Commit-Queue: Sean McCullough <seanmccullough@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Cr-Commit-Position: refs/heads/master@{#39729}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.