commit | 9b3719707b8c4c46a74be5951c4ad6cce22217fc | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Wed Oct 10 18:03:45 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 10 18:03:45 2018 |
tree | 8706844424a349bba42b3c3e9c8cd9f70de03a7e | |
parent | c3cc89944d2c1fc024dbeb00ebf7794cf0b81867 [diff] |
chrome views: Do not rely on MaterialDesignController forward declarations This fixes the libstdc++ build after #595275 ("Relayout browser windows when MD mode changes") and #596350 ("Relayout location bar buttons when MD mode changes"), which was failing with errors such as ../../base/scoped_observer.h: In instantiation of ‘void ScopedObserver<Source, Observer>::RemoveAll() [with Source = ui::MaterialDesignController; Observer = ui::MaterialDesignControllerObserver]’: ../../base/scoped_observer.h:26:14: required from ‘ScopedObserver<Source, Observer>::~ScopedObserver() [with Source = ui::MaterialDesignController; Observer = ui::MaterialDesignControllerObserver]’ ../../chrome/browser/ui/views/frame/browser_frame.h:156:24: required from here ../../base/scoped_observer.h:45:20: error: invalid use of incomplete type ‘class ui::MaterialDesignController’ sources_[i]->RemoveObserver(observer_); ~~~~~~~~~~~~~^~~~~~~~~~~~~~ which likely comes from libstdc++'s std::vector::operator[] needing more than a forward declaration to work. Bug: 819294 Change-Id: Iac577346cc706713a60d8cd0aa205bd14a0b7b5a Reviewed-on: https://chromium-review.googlesource.com/c/1273745 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#598398}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .