Google Git
Sign in
chromium / chromium / src / 9b866113743ca04361daf9e63c30ae190ca60da4
commit9b866113743ca04361daf9e63c30ae190ca60da4[log] [tgz]
authorZhiqiang Zhang <zqzhang@google.com>Thu Jul 12 21:13:24 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jul 12 21:13:24 2018
treedef237e3e9b0df3a4f3012defd8e7519d303a0ca
parent3e3bfb0e1c19b0fbc2321ee85724b7705106dc15 [diff]
[Android MR] Check Google Play services APK version before enabling CAF

This CL checks GMS APK version before enabling CAF. The reason is that
the current SDK version is 12.0.1, while we require the APK version to
be 12.6.0 or above to make it fully functional (this is to avoid
intializing the SDK in Activity#onCreate()).

Currently we are using a fallback implementation to check GMS APK
version. Ideally this should be done via the versioned
GoogleApiAvailability.isGooglePlayServiceAvailable() API. However this
versioned API is only added in a later version. The downstream
implementation is calling the versioned API directly.

After the upstream SDK version gets updated, we can just call the
versioned API directly.

Bug: 711860
Change-Id: Iec5f84cffcc5c55fd303255b91a7f187c79b15cb
Reviewed-on: https://chromium-review.googlesource.com/1132474
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574722}
2 files changed
tree: def237e3e9b0df3a4f3012defd8e7519d303a0ca
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .