Google Git
Sign in
chromium / chromium / src / 9b87a12fabc93c8dda609b4c00dd0a6b029baeca
commit9b87a12fabc93c8dda609b4c00dd0a6b029baeca[log] [tgz]
authorAlan Cutter <alancutter@chromium.org>Thu Jun 07 01:36:35 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jun 07 01:36:35 2018
treeee7155943b3708a913346b7e11374eeb3172ec05
parent7edcaa69bd673a05d58b958948b3f80d765e552f [diff]
Rename PageActionIconView::UpdateIcon() to UpdateIconImage()

This rename helps disambiguate Update() and UpdateIcon() by renaming the
latter as UpdateIconImage().
The former updates the view's visibility state while the latter updates
the vector icon used by painting.

Bug: 788051
Change-Id: I1a6d24ed404b5a2017e64ea9b064ada6de7865dd
Reviewed-on: https://chromium-review.googlesource.com/1088453
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565136}
4 files changed
tree: ee7155943b3708a913346b7e11374eeb3172ec05
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .