Google Git
Sign in
chromium / chromium / src / 9d044cd5a52b43df40bf00d75f8bccf3d47bf4d1
commit9d044cd5a52b43df40bf00d75f8bccf3d47bf4d1[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Wed Jul 25 03:32:27 2018
committerCommit Bot <commit-bot@chromium.org>Wed Jul 25 03:32:27 2018
tree10e6c0e39280228e415d4d5656cd2083a317b7bd
parenta1319271933c15e80b6e43e13ddce7e8df009e28 [diff]
[LayoutNG] CachedOffsetForPosition and CachedPositionForOffset for RTL

This patch enables ComputePositionData() for RTL, and enables
using the data in CachedOffsetForPosition and
CachedPositionForOffset.

Because we use binary search, CharacterPositionData stores
ShapeResultCharacterData in the visual order, so that its
|x_position| is in ascending order.

This patch also adds DCHECKs to ensure Cached and non-Cached
versions return the same data. Cases they don't were
discovered, in LTR and RTL. DCHECKs are limited to when it
passes, and failing cases are to be investigated.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ifaf3f9f73c7b098e68932e8dc0181a79c1d7778d
Reviewed-on: https://chromium-review.googlesource.com/1148025
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577786}
2 files changed
tree: 10e6c0e39280228e415d4d5656cd2083a317b7bd
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .