commit | 9d830c214cd1c59958ee19403b446fa5b796e794 | [log] [tgz] |
---|---|---|
author | Oystein Eftevaag <oysteine@google.com> | Fri Dec 07 01:16:41 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Dec 07 01:16:41 2018 |
tree | 728fd5c5e8ee286a0274d00e02e31e5918d5c41d | |
parent | 24fde26e7643d0bb161d27cc1a1b79432e5752e5 [diff] |
Reland "Perfetto: Stop splitting _COMPLETE events" This is a reland of 53e8b2a294d66219b5c4daf00dda1cb9f822a54f Relanding after https://chromium-review.googlesource.com/c/catapult/+/1364251 which is what caused the failures triggering the revert last time. Original change's description: > Perfetto: Stop splitting _COMPLETE events > > The current Perfetto backend splits _COMPLETE trace events into > separate _BEGIN and _END pairs, as it's not very feasible to modify > existing events after they're written into the Shared Memory Buffers. > > This is causing some issues with the trace-viewer which has some > assumptions about the ordering of begin/end events vs. async events, > and is also bloating the sizes of traces and adding extra > overhead for the perf infra. > > Instead, we now keep the _COMPLETE events in an internal stack in > TLS and only emit them when we have their duration. > TBR=eseckler@chromium.org,skyostil@chromium.org > > Bug: 909728,888558 > Change-Id: I80e37264de66d8bbcb6c9095d21047957fd6eb9f > Reviewed-on: https://chromium-review.googlesource.com/c/1354503 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612360} Bug: 909728, 888558 Change-Id: I5e3d6e0f170066011e2a5b452969d9c8cd18ac4f Reviewed-on: https://chromium-review.googlesource.com/c/1359304 Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#614540}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .