commit 9d8f49e506d0845cb7c78e883b3b5056b2efa71f
author Antonio Gomes <tonikitoo@igalia.com> Thu May 10 05:33:57 2018
committer Commit Bot <commit-bot@chromium.org> Thu May 10 05:33:57 2018
tree bab64d433246784ad87f7a962f8fd84df1fbe748
parent be40357406155063c188290e93c19a6f5b3aa742

Migrate GoogleURLTracker to SimpleURLLoader

Apart from the actual migration, CL also adapts the existing unittests
(namely GoogleURLTrackerTest, from components_unittests target) to work
with the SimpleURLLoader machinery.

Some remarks on the unittests' migration:

- GetFetcher calls in the unittests were replaced by handled_request.
- MockSearchDomainCheckResponse: rather than calling the URLFetcherDelegate
  method, it queue a server response to be served upon request.
- We call MockSearchDomainCheckResponse before instantiating any request.
- RequestServerCheck and FinishSleep both can trigger SimpleURLLoader download.
  Hence both methods add a loop in order to make sure a request is
  handled by the server (or failed).

Additionally, CL removes the dependency of URLRequestContextGetter from
GoogleURLTrackerClient. Derived classes are also updated accordingly.

Last, some unittests, namely browser_tests' ErrorPageAutoReloadTest,
stared to track additional "google url tracker" loads from its Interceptor.
Tests are updated to skip counting such loads.

BUG=773295

TBR=treib@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I416c6254876ce6a54ee239ff63cd35fc300d5053
Reviewed-on: https://chromium-review.googlesource.com/1042825
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557459}