| commit | 9e80d868029c25fdb129f85d0f8f75e8f6c013e1 | [log] [tgz] |
|---|---|---|
| author | kinuko <kinuko@chromium.org> | Fri Mar 10 07:15:41 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Fri Mar 10 07:15:41 2017 |
| tree | e5fcdd9e53f8b1fca2d493d60d57cbd1e30dfe31 | |
| parent | 72efd11d727f12bc45e74a1e6f7e379b3d6d5e2d [diff] |
Revert of Statically link libprotobuf_lite on Linux (patchset #2 id:20001 of https://codereview.chromium.org/2746493002/ ) Reason for revert: Not sure why, but it looks this starts to cause CloudPolicyManagerTest failures. (Confirmed that locally reverting this CL fixed them) https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39213 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/39214 CloudPolicyManagerTest.Register CloudPolicyManagerTest.RegisterWithRetry failed to process gtest output JSON CloudPolicyProtoTest.VerifyProtobufEquivalence Original issue's description: > Statically link libprotobuf_lite on Linux > > Chrome has a direct dependency on a custom libprotobuf_lite in > third_party, but Xenial and Yakkety add a dependency on the system > libprotobuf-lite via Mir (which gets loaded from Gtk). > > Our third_party protobuf is not compatible with the upstream protobuf. > Combine this with the fact that Xenial uses version 2 while Yakkety > uses version 3, and it's basically impossible to make our third_party > protobuf cooperate with the system one. The solution is to always > statically link protobuf on Linux. > > BUG=79722,700120 > R=pkasting@chromium.org > TBR=bengr@chromium.org > CC=dpranke@chromium.org,rsimha@chromium.org > > Review-Url: https://codereview.chromium.org/2746493002 > Cr-Commit-Position: refs/heads/master@{#455936} > Committed: https://chromium.googlesource.com/chromium/src/+/4af1264005620a483a209f4344c3782f62eee69a TBR=pkasting@chromium.org,bengr@chromium.org,thomasanderson@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=79722,700120 Review-Url: https://codereview.chromium.org/2739203004 Cr-Commit-Position: refs/heads/master@{#456013}