commit | 9f872a03a892c1fcc393a9912a4c5d3e1d8bc8ee | [log] [tgz] |
---|---|---|
author | Dmitry Gozman <dgozman@chromium.org> | Tue Nov 13 04:30:59 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Nov 13 04:30:59 2018 |
tree | 5d11f2f0f12aba92c63911e453e11048fa29d7d4 | |
parent | 75429d4ae805e82e1bf8517246a492af60939c7b [diff] |
FrameLoader: only commit a navigation from an explicit call This replaces WebLocalFrameClient::DecidePolicyForNavigation with BeginNavigation, where client may decide how to proceed. Typically, the client would just call CommitNavigation to commit the requested navigation. However, for browser-side navigation, we do instead ask browser to proceed, and temporarily call CreatePlaceholderDocumentLoader. After this patch, we can start removing WebLocalFrameClient callbacks, like {Did,Will}StartProvisionalLoad, since the client now controls the navigation flow and doesn't need a callback. Bug: 855189 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic995073e191a238ac46ae6be2114af596e41425f Reviewed-on: https://chromium-review.googlesource.com/c/1271411 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#607486}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .