commit | 9ff2c0d617b1e5ae141e017065df1d45ce6b46ac | [log] [tgz] |
---|---|---|
author | George Burgess IV <gbiv@chromium.org> | Fri Dec 11 18:33:03 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Dec 11 18:33:03 2020 |
tree | 356fc97c9ecdd5cb013e25851d0dc21499946956 | |
parent | 03e41c0540df6d2841920b4488f2e39420c450a6 [diff] |
tricium_clang_tidy: refactor tests to use a fn to build diagnostics No functional change is intended. We have a number of fields that get inited to the same default, and I plan to add another. Seems better to hide these default values in test-cases where they shouldn't matter. Bug: 1157503 Change-Id: I8a8fa9507e39498e526a1f2aecde55249c5b04da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2586004 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*
), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores
, with the exception of the special functions RunSteps
and RunTests
in recipes. Use yapf (git cl format --no-clang-format
) to autoformat new code.