Allow proxying plaintext websockets over http/2 proxy
Both secure and insecure websockets are proxied using HTTP CONNECT
tunnels. But if secure proxy supports HTTP/2 plaintext websockets won't
work (ERR_NOT_IMPLEMENTED will be returned).
To initiate standard websocket handshake over established tunnel, in
HttpStreamFactoryImpl::Job::DoCreateStream we should follow
if (!using_spdy_) { ... } code branch, otherwise we end up in
SetSpdyHttpStreamOrBidirectionalStreamImpl which returns
ERR_NOT_IMPLEMENTED for websocket requests.
For wss: scheme, everything works, since ProxyClientSocket (which is
HttpProxyClientSocketWrapper) is wrapped with SSLClientSocket
establishing TLS connection over the tunnel,
HttpStreamFactoryImpl::Job::DoInitConnectionComplete works as
expected. But for ws: scheme, |using_ssl_| is false,
|proxy_info_.is_https()| is true and we get into the branch where
|using_spdy_| is set to true (which is fine for non-websocket
requests).
This change adds very cumbersome condition allowing plaintext
websockets requests over HTTP/2 proxies follow the same code path
secure websockets do.
BUG=684681
TEST=HttpNetworkTransactionTest.PlaintextWebsocketOverSpdyProxy
R=mmenke@chromium.org,ricea@chromium.org
Review-Url: https://codereview.chromium.org/2642723008
Cr-Commit-Position: refs/heads/master@{#446020}
2 files changed
