commit | a07fcc7eff327a136389ae23b91d2321020730f1 | [log] [tgz] |
---|---|---|
author | Dmitry Gozman <dgozman@chromium.org> | Thu Nov 15 17:58:17 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 15 17:58:17 2018 |
tree | b0bb17d3fc4176b3baa6b696ede1436a6e979a3d | |
parent | 4aa8099d54f2ad3bffd3a588b56acd471a45d702 [diff] |
RenderFrameImpl: simplify error page handling part2 - Inline DidFailProvisionalLoadInternal to the callsites, and carefully avoid the logic which is only needed in one place. - Move EnableViewSourceMode(false) to the most inner method which is used for error page loading, since we were missing it in some call paths. - When committing failed navigation, we use the newly constructed "failed_request" instead of taking one from the provisional loader. At some point, there will be no provisional loader to take the request from, so we might as well switch right now. Bug: 855189 Change-Id: Idf9eba3c3014c1e68a860ceff6051f1ff576062c Reviewed-on: https://chromium-review.googlesource.com/c/1332700 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608427}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .