commit a12c770e918a69cc0bbba2d2579c22ff6ae76936
author Bence Béky <bnc@chromium.org> Wed Dec 06 21:07:28 2017
committer Commit Bot <commit-bot@chromium.org> Wed Dec 06 21:07:28 2017
tree a6953b4a6ccb9f96ef66674bbf8c4744d4f13782
parent 242b9b0d6af44d087f29d3a1ed389242efcda5fc

Record stream IDs in Http2PushPromiseIndex.

Stop using SpdySession instances in Http2PushPromiseIndexTests.  This
makes tests much simpler.

Rename SpdySessionKey::Equals() to SpdySessionKey::operator==() so that
it can be tested by gMock.  This conforms to the style guide "prefer to
define == [...] rather than Equals()", see
https://google.github.io/styleguide/cppguide.html#Operator_Overloading

Define struct UnclaimedPushedStream instead of using std::pair or
std::tuple.  Named members are much nicer than first, second, or get<>.

Define CompareByUrl in conformance with the same section of the style
guide "if your type doesn't have a natural ordering [...] use a custom
comparator rather than overloading <".

The next CL will merge SpdySession::UnclaimedPushedStreamContainer into
Http2PushPromiseIndex.  For this, two sets of UnclaimedPushedStream
entries will need to be maintained with identical
contents but different ordering.  The other will be done by
CompareByDelegate and will allow efficient lookup of entries for a given
Delegate.

Bug: 776415, 791054
Change-Id: I0c1912e9932b102e17528f9319163232860a8813
Reviewed-on: https://chromium-review.googlesource.com/809187
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522192}