commit | a238f8b984a1b09449ae92abd23f32576d098c96 | [log] [tgz] |
---|---|---|
author | Marc Treib <treib@chromium.org> | Tue Oct 23 10:23:08 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Oct 23 10:23:08 2018 |
tree | 9a1ffc4878bd6b5129573f28136a61882d9827bd | |
parent | ac3d821a47de6a2349785109aa38f2844e6fc7a4 [diff] |
Sync: Reconfigure whenever a SyncSetupInProgressHandle is released Before: Reconfigure Sync only when the *last* handle is released. After: Reconfigure Sync whenever a handle is released, whether there are any others or not. On desktop, this fixes the case where a chrome://settings/syncSetup tab is left open and forgotten somewhere, which previously prevented Sync from ever applying new settings. On Android/iOS, only one Sync setup UI can be visible at a time, so this doesn't change any behavior. However, we now need to be careful not to needlessly re-create the handle. Bug: 884159 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib61d063ac8b6e76d05a5b72d17de7b1e031a51dd Reviewed-on: https://chromium-review.googlesource.com/c/1280208 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601899}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .