commit a313523de7459067fcf26947447ca768a1d34fa9
author Dmitry Gozman <dgozman@chromium.org> Tue Jan 08 19:39:33 2019
committer Commit Bot <commit-bot@chromium.org> Tue Jan 08 19:39:33 2019
tree e16be54f0f4e56f54abed0b7de207cb6e091862c
parent 39ecb197c8932f7e2951c9e186d9de69c98af1b6

Prepare various places to synchronous navigation commit

Once we start committing synchronously, some assumptions
about asynchronous flow will be broken. This patch updates
multilple places which can be updated separately (mostly tests).

WebFrameTest.ReplaceNavigationAfterHistoryNavigation is committing
a failing url, which does not happen in production anymore - we
commit an error page instead. It's functionality is covered
by RendererErrorPageTest, so removing.

WebFrameTest.BackDuringChildFrameReload has been migrated to
web_tests/http/tests/navigation/back-during-child-frame-reload.html.

WebFrameTest.LoadHistoryItemReload is only checking CacheMode
when committing navigation, which is useless since in production
this cache mode is handled on the browser and ignored in renderer.

See an example of synchronous commit for SubstitueData,
which requires all these changes:
https://chromium-review.googlesource.com/c/chromium/src/+/1389945.

Bug: 855189
Change-Id: Ib198d2373539113b4721ff5767da00794cb1a42f
Reviewed-on: https://chromium-review.googlesource.com/c/1392099
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620839}