commit | a35a7fe2bea84fe913ea585ba642357279e0a5cf | [log] [tgz] |
---|---|---|
author | A Olsen <olsen@chromium.org> | Tue Oct 02 09:41:10 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Oct 02 09:41:10 2018 |
tree | d6669b667ca89c9c32760e776683cf586bfc4fe7 | |
parent | 407a6141e74ec93c3c9594f05a5ac7946d07247c [diff] |
SystemSettingsProvider dep back to LoginState SystemSettingProvider had a dep on both LoginState and ProfileManager, in order to check if the user had permission to change the timezone. ProfileManager is in chrome/browser and I am trying to remove chrome/browser deps, so I changed the code to use only UserManager. See https://chromium-review.googlesource.com/1238450 I realized afterwards that UserManager deps are also currently not allowed in src/chromeos, where this code will soon live. Rather than expand the list of deps (which should be kept small), I have updated LoginState so that only it is needed here (instead of ProfileManager or UserManager). So, the last change is no longer needed, and is reverted. I also tidied up conversion code in ChromeUserManager slightly - Moving if-else-else chain into a helper function with switch + return means that the compiler checks that all cases are handled. Bug: 446937 Change-Id: I3aa44cacdef752f997d12b647d6e073f806371d3 Reviewed-on: https://chromium-review.googlesource.com/1249209 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595777}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .