Google Git
Sign in
chromium / chromium / src / a36e6e1d9422377bb173d2c1139e66276933c51c
commita36e6e1d9422377bb173d2c1139e66276933c51c[log] [tgz]
authorAvi Drissman <avi@chromium.org>Mon Dec 24 23:55:04 2018
committerCommit Bot <commit-bot@chromium.org>Mon Dec 24 23:55:04 2018
tree48b51c4e22e19bafe4682f3f7a5c4e9d64b1e891
parent92d47cc92a00edfb6aa7c7878db0565bd17ca964 [diff]
Revert "[DL]: Ensure to reject update/commit promises on disconnected elements."

This reverts commit 5f4ce97e16f4a7c1d57f5685ad230923285cf549.

Reason for revert: On https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29?limit=200, virtual/display-lock/display-lock/lock-before-append/acquire-update-measure-remove.html has been failing about 90% of the time since this landed.

Original change's description:
> [DL]: Ensure to reject update/commit promises on disconnected elements.
> 
> This patch ensures that we reject update/commit when it happens on
> a disconnected element.
> 
> R=​chrishtr@chromium.org
> 
> Bug: 882663
> Change-Id: Iaee923a4f41714b437c0a2b85bbb175359a2f32c
> Reviewed-on: https://chromium-review.googlesource.com/c/1387944
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618713}

TBR=vmpstr@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 882663
Change-Id: I491a3f7db511a69f2538e3158bc4666c6f9eaf85
Reviewed-on: https://chromium-review.googlesource.com/c/1390433
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618847}
6 files changed
tree: 48b51c4e22e19bafe4682f3f7a5c4e9d64b1e891
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .