commit a3d3dcaba84b52c1ad798a4ed3137c33a5cf5bc6
author Marc Treib <treib@chromium.org> Tue Jan 15 07:35:17 2019
committer Commit Bot <commit-bot@chromium.org> Tue Jan 15 07:35:17 2019
tree f870fcc8bb38c8f182802069b46a5e8f3ef4b8a7
parent 832344741e9759d0acb306990364cafba4a127b6

Cleanup in ProfileSyncService::RequestStart

Previously, RequestStart would early-out (*before* actually setting the
SyncRequested pref) if there was a disable reason ENTERPRISE_POLICY or
PLATFORM_OVERRIDE. However, there's no reason for such a constraint,
and it's not enforced consistently anyway (e.g. if SyncRequested is
already set when DISABLE_REASON_ENTERPRISE_POLICY comes in, it's not
cleared).

This CL changes the method to always set SyncRequested. This makes
things a bit simpler, and it should make no actual difference in
practice: If there are other reasons to keep Sync disabled, then those
will still prevent it from starting (checked in ShouldStartEngine).

Bug: 884159
Change-Id: Ib97da48203f3880a8c5366de783a06eee15f62dd
Reviewed-on: https://chromium-review.googlesource.com/c/1404269
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622765}