commit | a4eea1bad542e7a65e928a5646ef8151dea37237 | [log] [tgz] |
---|---|---|
author | Weiwei Lin <weiweilin@google.com> | Thu Mar 18 06:53:14 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 18 06:53:14 2021 |
tree | 7d64d83f28ae7bcdee5e29e2f46f4311b26e51f7 | |
parent | c31c958d4aa3a003a93e6223032e64802feb0438 [diff] |
Revert "[build] Disable building Milo GAE tarball." This reverts commit ee49c6ec3b5aed14756bc4858425a77479656595. Reason for revert: Milo GAE tarball is reproducible again after removing workbox source maps. Original change's description: > [build] Disable building Milo GAE tarball. > > It is building non-reproducibly now causing a lot of churn (by > producing a roll CL and deploying luci-milo-dev on every infra.git > commit). > > Disable it until it is fixed. > > R=​iannucci@chromium.org, tandrii@chromium.org > BUG=1189309 > > Change-Id: Iee9f5268a8686ddb52d0d09b60d8661086c11398 > Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2768565 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#39457} Bug: 1189309 Change-Id: I47577822c528c7db2347bd4650d8cb592ad7aa5e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2771067 Auto-Submit: Weiwei Lin <weiweilin@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#39478}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.