commit | a6e9d0f17354896ffc664d83854aea747735cc21 | [log] [tgz] |
---|---|---|
author | Dean Michael Berris <dberris@google.com> | Wed Apr 14 11:50:30 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Apr 14 11:50:30 2021 |
tree | fed9a85aa478224a0d5217c4ac7205524afa33af | |
parent | fbf608630d7590bf0023b8d1aee009ec802e926d [diff] |
pinpoint: Increase validation of inputs This change adds more testing coverage and ensures we're testing some required inputs for Pinpoint jobs being started on the legacy service, with better error messages. R=abennetts@google.com, fancl@chromium.org Bug: chromium:1175615, chromium:1198821 Change-Id: I36bf8990c4a5374feb319f67b478f9fd28c6bf7a Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2823200 Commit-Queue: Dean Berris <dberris@chromium.org> Auto-Submit: Dean Berris <dberris@chromium.org> Reviewed-by: Chenlin Fan <fancl@chromium.org> Cr-Commit-Position: refs/heads/master@{#40160}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.