commit | a777927d9ca90acd0590bf12fc340f038657705f | [log] [tgz] |
---|---|---|
author | arthursonzogni <arthursonzogni@chromium.org> | Mon May 28 15:43:02 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon May 28 15:43:02 2018 |
tree | 08006d297976fbd7d443cac9c1c8a8b099cbc95b | |
parent | 3032d726d13da0c1da0917f363de2a4e7f1b73e7 [diff] |
Update inspector protocol test that relied on timing. I am working on https://crbug.com/831155. Some tests that are relying on how things are scheduled in Blink are failing. This CL makes 2 tests to keep working. * inspector-protocol/page/frameAttachedDetached.js * inspector-protocol/sessions/page-frame-events.js In these two tests, a frame is navigated twice. Immediately after the first load starts, a second navigation is requested. The tests expect Page.OnFrameStartedLoading to be called twice. The issue is the first load may not be finished when the second navigation is started. ProgressTracker::ProgressStarted() doesn't send the frameStartedLoading() if the frame is already loading something when FrameLoader::StartLoading is called. To fix the issue, the tests now wait for the frame to stop loading before navigating again. Bug: 831155 Change-Id: Iee71767be6d15dbf53c370bb414fe57015dd1df6 Reviewed-on: https://chromium-review.googlesource.com/1071791 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#562267}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .