| commit | a7a70da79ed53f56f5150bb7d1eb577aca51c457 | [log] [tgz] |
|---|---|---|
| author | Yiwei Zhang <yiwzhang@google.com> | Wed Feb 19 18:29:33 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 19 18:29:33 2020 |
| tree | 36788ec78a877289760e37c2f5f398d82bf4ef4a | |
| parent | 33fed4343ba9723f8d4e16dd04978f27490f0a57 [diff] |
[bb] Fix the bug that search api only returns 1000 builds max when limit>1000 The existing implementation will only make one request to buildbucket with page size set to the provided limit. On buildbucket server side, pagesize over 1000 will be treated as 1000. So the maximum number of builds inside the response will be 1000(assuming single predicate). The api will then return the builds directly instead of keeping paging till reaching the provided limit. This change switch the internal implementation from `bb batch` to `bb ls` which handles the `limit` parameter properly. This commit also includes some changes to fix the line wrap in presubmit warning. R=iannucci, nodir, tandrii Bug: 1039823 Change-Id: Iabeca7e638d2ca75479413ac47c3bb4dfa861054 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: fuchsia Recipe-Nontrivial-Roll: build_limited_scripts_slave Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/recipes-py/+/2051041 Commit-Queue: Yiwei Zhang <yiwzhang@google.com> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Recipes are a domain-specific language (embedded in python) for specifying sequences of subprocess calls in a cross-platform and testable way.
They allow writing build flows which integrate with the rest of LUCI.
Documentation for the recipe engine (including this file!). Take a look at the user guide for some hints on how to get started. See the implementation details doc for more detailed implementation information about the recipe engine.
user.email and user.name are configured in git config.Run the following to setup the code review tool and create your first review:
# Get `depot_tools` in $PATH if you don't have it git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools export PATH="$PATH:$HOME/src/depot_tools" # Check out the recipe engine repo git clone https://chromium.googlesource.com/infra/luci/recipes-py $HOME/src/recipes-py # make your change cd $HOME/src/recipes-py git new-branch cool_feature # hack hack git commit -a -m "This is awesome" # This will ask for your Google Account credentials. git cl upload -s -r joe@example.com # Wait for approval over email. # Click "Submit to CQ" button or ask reviewer to do it for you. # Wait for the change to be tested and landed automatically.
Use git cl help and git cl help <cmd> for more details.