commit | a7b541267263fa48be66f29fbe346cc403ccafba | [log] [tgz] |
---|---|---|
author | David Grogan <dgrogan@chromium.org> | Thu Nov 01 00:10:37 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Nov 01 00:10:37 2018 |
tree | bb43e8702afbeedb1f299f5120903a58d06b7986 | |
parent | 70536c5b1d5a3c52c1f30e72e0d5cd86bf908888 [diff] |
[LayoutNG] Make flexboxes stretch their items Includes moving the stretched size computation from legacy to FlexItem so that NG can use it. A big hack is that stretched items don't use the height of their parent lines, they use the whole container height because we haven't implemented line size calculation yet. This works for the majority of cases. About 6 tests newly fail. Some multi-line flex containers now fail because of the above hack. But some tests with images that are flex items fail because NG doesn't copy their data to legacy because there are unplaced floats internal to the image (something related to alt text). I haven't looked into why this used to work but fails now. This patch nets roughly 110 layout test lines removed. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I0083e80797c1f01c8cc4c63ac696d68063f67ff2 Bug: 845235 Reviewed-on: https://chromium-review.googlesource.com/c/1285851 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604457}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .