commit | a7d6d9872e267e3e970707e394e84092177b357d | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Wed Jun 20 21:33:02 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jun 20 21:33:02 2018 |
tree | 20199d0730553a3c2f95783855cefc9a91174269 | |
parent | 16495a74b2c3e5b07094c6184ab89509b0d9468f [diff] |
media capture, mojo: Sprinkle noexcept in a few more classes Commit fc5fe70812c ("FrameSinkVideoCapture clean-up: Remove unused APIs, style fixes") added the noexcept marker to FrameSinkVideoCapture's ConsumptionState inner class. This breaks the GCC build due to the fact that its members' types do not have noexcept themselves: ../../content/browser/media/capture/frame_sink_video_capture_device.cc: At global scope: ../../content/browser/media/capture/frame_sink_video_capture_device.cc:372:1: error: function ‘content::FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState(content::FrameSinkVideoCaptureDevice::ConsumptionState&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ FrameSinkVideoCaptureDevice::ConsumptionState::ConsumptionState( clang is fine because we pass -fno-exceptions and it disables the same error there, while GCC continues to raise it (bug 843143 and its corresponding CL have a longer discussion on this issue). In this case, mark CursorRendererUndoer as well as mojo's ubiquitous InterfacePtr with noexcept to fix the build. Bug: 754872, 819294, 843143 Change-Id: I78714fda26d21e0979aed4fe26d543463dff9631 Reviewed-on: https://chromium-review.googlesource.com/1107918 Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#569029}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .