commit | a9cbf22afd4ec4305334c7f953c15fc849043854 | [log] [tgz] |
---|---|---|
author | Friedrich Horschig <fhorschig@chromium.org> | Thu Jan 11 13:30:05 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 11 13:30:05 2018 |
tree | 034088d7f65b8dd3197b5ea90471a441845ffbab | |
parent | 27fb73c666780e66a2013dc27aafb5283fde6af8 [diff] |
Revert "Reland "Do not reveal username value till user gesture."" This reverts commit 3d4d84928567f74d93d951932eafa1b3d779923b. Reason for revert: ASan failed interactive_ui_tests with a PasswordManagerBrowserTestBase.UsernameChanged failure. A connection seems likely. Could you please check that? Build: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20ASan%20Tests%20%28sandboxed%29/builds/42632 Original change's description: > Reland "Do not reveal username value till user gesture." > > Original change's description: > > Passwords are not available for a page till user gesture. > > But for usernames it was not implemented. This patch implements > > this: use SetSuggestedValue for username and register > > username_element to gatekeeper, which manages revealing > > the input suggested value to JS after user action. > > > > Along the way, a small improvement was implemented, setting > > the username value only in one place which simplifies the code. > > > Bug: 798492 > > Change-Id: Ib37637dd861f44b94674c6d0060ebc91dfd73cff > > Reviewed-on: https://chromium-review.googlesource.com/850394 > > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > > Reviewed-by: Dominic Battré <battre@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#527598} > > Original Patch is PatchSet 1. > Flakiness was fixed on CL https://chromium-review.googlesource.com/c/chromium/src/+/859960 > This CL differs from original only in small compilation fix in PatchSet 5 (compilation > errors were because of changes in another CL). > > TBR=battre@chromium.org > > Bug: 798492 > Change-Id: Ife2f67ca2cd75372ef388d077acb9d53b47be92d > Reviewed-on: https://chromium-review.googlesource.com/854173 > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528593} TBR=dvadym@chromium.org Change-Id: I081c713b5fe18b3d01d996eee4167000ef0bb906 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 798492 Reviewed-on: https://chromium-review.googlesource.com/860381 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#528615}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .