| commit | a9e93572d42663867fc62ef456b4fb1a92234c5a | [log] [tgz] |
|---|---|---|
| author | Clemens Hammacher <clemensh@chromium.org> | Mon Jan 28 16:21:40 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 01 10:13:30 2019 |
| tree | 8adb6f85a46d7ad7769fbd33602af4c91d5f8d90 | |
| parent | a03581e4f3e3cf0a7a21afc71cad63d14a8e2b36 [diff] |
[test] Check for illegal uses of mjsunit methods The assertThrows and assertDoesNotThrow methods expect either a function to execute, or a string to eval. In several tests however we accidentally passed the *result* of the statement to be tested instead of the code. This CL adds check to catch such error early, and removes wrong uses. In most places, we do not need to use assertDoesNotThrow anyway, because exceptions are handled as test failures. Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate MjsUnitAssertionErrors correctly. R=mathias@chromium.org Bug: v8:8562 Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49 Reviewed-on: https://chromium-review.googlesource.com/c/1439238 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59277}
V8 is Google's open source JavaScript engine.
V8 implements ECMAScript as specified in ECMA-262.
V8 is written in C++ and is used in Google Chrome, the open source browser from Google.
V8 can run standalone, or can be embedded into any C++ application.
V8 Project page: https://github.com/v8/v8/wiki
Checkout depot tools, and run
fetch v8
This will checkout V8 into the directory v8 and fetch all of its dependencies. To stay up to date, run
git pull origin
gclient sync
For fetching all branches, add the following into your remote configuration in .git/config:
fetch = +refs/branch-heads/*:refs/remotes/branch-heads/*
fetch = +refs/tags/*:refs/tags/*
Please follow the instructions mentioned on the V8 wiki.