Google Git
Sign in
chromium / chromium / src / ae872ca32aacde2d3449ceb40c1160dd7b304bd4
commitae872ca32aacde2d3449ceb40c1160dd7b304bd4[log] [tgz]
authorDmitry Gozman <dgozman@chromium.org>Tue Jan 08 04:51:47 2019
committerCommit Bot <commit-bot@chromium.org>Tue Jan 08 04:51:47 2019
tree27e99a3ec700598b37f9cf55fc7e6375318472d0
parent0a92e4939b0c788b498c83a8a82641e87d3fff49 [diff]
Do not commit navigation to an arbitrary request in TestRenderFrame

As a part of removing provisional document loader (see doc linked
from the bug, step 6.d), we plan to stop using WebURLLoader for
navigation requests. This means there will be no artificial
WebURLRequest created for the main resource, DocumentLoader::request_
and WebNavigationParams::request will be gone.

Passing arbitrary request to CommitNavigation will not work anyway,
since we are not faking network in these tests. In fact, we are only
using about:blank, about:srcdoc and data urls for subframes,
which we can explicitly handle.

Bug: 855189
Change-Id: Ia87d2584dc0fb8d6a6142dc15cc12492f29dfdfb
Reviewed-on: https://chromium-review.googlesource.com/c/1385473
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620623}
1 file changed
tree: 27e99a3ec700598b37f9cf55fc7e6375318472d0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .