commit | aef33f11cd7ce7d81c98205c845f2c6a79ce74df | [log] [tgz] |
---|---|---|
author | Findit <findit-for-me@appspot.gserviceaccount.com> | Thu Nov 08 03:27:35 2018 |
committer | Findit <findit-for-me@appspot.gserviceaccount.com> | Thu Nov 08 03:27:35 2018 |
tree | 0de915d1baba60d2fe37a22e13f2a698da756872 | |
parent | 78d31c19a31277dc9690df98c7c1c64009256695 [diff] |
Revert "Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow" This reverts commit b43c6fca4349b7f2ff53b41926f5d7cb42ee4e0f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 606292 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I0M2M2ZmNhNDM0OWI3ZjJmZjUzYjQxOTI2ZjVkN2NiNDJlZTRlMGYM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/24981 Sample Failed Step: webkit_unit_tests Original change's description: > Make NGOffsetMapping available for non-LayoutNG LayoutBlockFlow > > This patch allows computing NGOffsetMapping for legacy inline > formatting context. > > For an experimental project "Invisible DOM"[1][2] to support > the find-in-page feature, it is needed to compute the text > content with whitespace collapsing applied, along with the > mapping to the DOM offset. This patch adds an API to compute > NGOffsetMapping even when the LayoutBlockFlow is not laid out > by LayoutNG for that purpose. > > Note that the project is still in the early phase. We may > revisit the design as it moves forward. > > [1] https://github.com/rakina/searchable-invisible-dom > [2] https://www.chromestatus.com/feature/5105291213406208 > > Bug: 636993, 873057 > Change-Id: I101b411960813a7b9b5c9c6e2db85d28737af882 > Reviewed-on: https://chromium-review.googlesource.com/c/1322184 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606292} Change-Id: I7942801d9268078959619af61363c3a769fc0a53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 636993, 873057 Reviewed-on: https://chromium-review.googlesource.com/c/1325350 Cr-Commit-Position: refs/heads/master@{#606316}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .