commit | af006e4fcb3f80d6881039306b7fcd429d2275fb | [log] [tgz] |
---|---|---|
author | Kentaro Hara <haraken@chromium.org> | Fri Aug 17 03:50:51 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Aug 17 03:50:51 2018 |
tree | d8ff37ccd4387a77d9631b265e509aec2090447a | |
parent | 04d80b5db7f3d2f9518c44b40bf4704e6fcd2eec [diff] |
Revert "[Mac] Moved TextSuggestionsTouchBarController's Range Validity Check" This reverts commit 8fd04b5fbba25e412874ff15c659c25fb9dcc12c. Reason for revert: TextSuggestionsTouchBarControllerTest.InvalidRange started failing https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28606 Original change's description: > [Mac] Moved TextSuggestionsTouchBarController's Range Validity Check > > Previously, -updateTextSelection:range:offset: could receive an invalid > range from WebContentsTextObserver::DidChangeTextSelection(). This > invalid range would then cause a crash in -requestSuggestions. > > A check has been added to -updateTextSelection:range:offset: to make > sure that a selection with an invalid range is not passed to > -requestSuggestions. This should prevent future crashes. > > TextSuggestionsTouchBarControllerTest.InvalidRange tests that an > invalid range does not crash the controller and is handled > properly. > > Bug: 717553 > Change-Id: I69f49cb1f1819e1d528837767dfb894d8652e84d > Reviewed-on: https://chromium-review.googlesource.com/1178467 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Sarah Chan <spqchan@chromium.org> > Commit-Queue: Tessa Nijssen <tnijssen@google.com> > Cr-Commit-Position: refs/heads/master@{#583815} TBR=avi@chromium.org,spqchan@chromium.org,tnijssen@google.com Change-Id: I7735c373052037bb377c1beac79d7b1132f3bc86 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 717553 Reviewed-on: https://chromium-review.googlesource.com/1179382 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#583954}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .