Google Git
Sign in
chromium / chromium / src / af00b29ef10cda1bec17f975930ac23de6375da9
commitaf00b29ef10cda1bec17f975930ac23de6375da9[log] [tgz]
authorMomoko Sumida <momon@google.com>Thu Aug 09 09:10:45 2018
committerCommit Bot <commit-bot@chromium.org>Thu Aug 09 09:10:45 2018
tree586100dcf95d595c68566d7ac776b9c37edbe6b7
parent9969398c03e8328120139aded02d6ff42269220f [diff]
Delete constructor for creating empty CSSStyleSheets

Currently, empty CSSStyleSheets can be constructed either with a constructor or with Document.createEmptyCSSStyleSheet.
This CL deletes the constructor so that they can only be produced by Document.createEmptyCSSStyleSheet.

Document.createEmptyCSSStyleSheet is considered to be more desirable, as CSSStyleSheets produced by Document.createEmptyCSSStyleSheet can be tied to documents in the future. This means that their use can be limited in the documents where they were produced, resulting in higher security.

Note:
The constructed CSSStyleSheet is not currently tied to the Document yet

Link to related comments in discussion:
https://github.com/WICG/construct-stylesheets/issues/23#issuecomment-379180786
https://github.com/WICG/construct-stylesheets/issues/15#issuecomment-391216056

Bug: 807560
Change-Id: I767e15e83e1f31eb278bc81233c8b579d0f511c7
Reviewed-on: https://chromium-review.googlesource.com/1164876
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Momoko Sumida <momon@google.com>
Cr-Commit-Position: refs/heads/master@{#581836}
8 files changed
tree: 586100dcf95d595c68566d7ac776b9c37edbe6b7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .