| commit | afb04d5cbb8b547073d54a3019bcf21ecfc48601 | [log] [tgz] |
|---|---|---|
| author | Greg Thompson <grt@chromium.org> | Fri Oct 02 16:22:18 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 02 16:22:18 2020 |
| tree | 000904ffc4ad08dda872a4ec85afce7fb65a6b1f | |
| parent | 2327783322dc8505f104208052a64a9ca3d0c9bb [diff] |
Revert "Reland "Remove --isolated-script-test-perf-output from chromium recipe."" This reverts commit 29509aa87a6785e3fcfd5e6b52407a6a6194f239. Reason for revert: I think this is breaking official builds on release branches. r810743 probably needs to be merged to all active release branches before landing this change. Original change's description: > Reland "Remove --isolated-script-test-perf-output from chromium recipe." > > This is a reland of 98cb0022b0e4f2c6b05a23b31bfe532ed9924885. > > It turned out that the arg was used way in at least one place. > That usage was removed in https://crrev.com/c/2429866, so let's > try to land this again and see what happens. > > Original change's description: > > Remove --isolated-script-test-perf-output from chromium recipe. > > > > As discovered/discussed in crbug.com/1127545, it appears that this > > flag is not actually ever used anywhere in the chromium recipes. > > > > Perf tests *do* produce output, but they don't use this flag to > > do so. > > > > WebRTC tests *do* use this flag, but they set this directly in their > > own recipes. > > > > Bug: 1127545 > > Change-Id: I215ad8f698c18e41ca2a87c7043371a9ac73000b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2427305 > > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > TBR=martiniss@chromium.org > Bug: 1127545 > Change-Id: I57743d353893d310adafe88df7c0fcc7858c9048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2431697 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> No-Try: true Bug: 1127545 Change-Id: I536bc36470449e36f8c909b493e7a71e2037ce6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2443652 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Dirk Pranke <dpranke@google.com> Commit-Queue: Greg Thompson <grt@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.