commit | b06974abd43560ae11fe5a98fa63245d0fe3d5f8 | [log] [tgz] |
---|---|---|
author | Nasko Oskov <nasko@chromium.org> | Sat Dec 22 01:04:27 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Dec 22 01:04:27 2018 |
tree | 769ae1ee43e2164f034dfe22f5b59d7382ac13ed | |
parent | 5f9e4ce62896c2b2daee1e0e2f87eaf2b2d96df5 [diff] |
Revert "Replace security state workaround in CanAccessDataForOrigin()" This reverts commit 263ce44bb356617e098d2cbad147146e0a36fc64. Reason for revert: There are still renderer process terminations due to this CL, see details in https://crbug.com/915203#c9. Original change's description: > Replace security state workaround in CanAccessDataForOrigin() > > - Replace workaround with code that is more strict about enforcing > security policy during child process shutdown. The old code would > always allow data access for IDs not in the security_state_ map. The > new code adds a pending map so we can deal with UI/IO thread races > during child process removal AND rejects any unknown IDs. > > - Fixed a test that depended on the old behavior where unknown IDs > always allowed access. > > Bug: 898281, 600441, 915203 > Change-Id: I26ca1e48536672b05d2310d8a17be47d5b6ef5c7 > Reviewed-on: https://chromium-review.googlesource.com/c/1382855 > Commit-Queue: Aaron Colwell <acolwell@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617937} TBR=acolwell@chromium.org,tsepez@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 898281, 600441, 915203 Change-Id: I3fa9efdede12c4403ace0df0678049358009e4e4 Reviewed-on: https://chromium-review.googlesource.com/c/1389025 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#618700}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .