blob: f4bfa76fd85a2d329d7723affc8a0e4dd4de7d7c [file] [log] [blame]
// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/wm/workspace/workspace_window_resizer.h"
#include "ash/public/cpp/shell_window_ids.h"
#include "ash/screen_util.h"
#include "ash/shelf/shelf.h"
#include "ash/shelf/shelf_constants.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/window_factory.h"
#include "ash/wm/window_positioning_utils.h"
#include "ash/wm/window_state.h"
#include "ash/wm/window_util.h"
#include "ash/wm/wm_event.h"
#include "ash/wm/workspace/phantom_window_controller.h"
#include "ash/wm/workspace_controller.h"
#include "base/command_line.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/stringprintf.h"
#include "services/ui/public/interfaces/window_tree_constants.mojom.h"
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/test/test_window_delegate.h"
#include "ui/aura/test/test_windows.h"
#include "ui/aura/window_event_dispatcher.h"
#include "ui/base/hit_test.h"
#include "ui/display/display_layout.h"
#include "ui/display/manager/display_manager.h"
#include "ui/display/screen.h"
#include "ui/display/test/display_manager_test_api.h"
#include "ui/events/gesture_detection/gesture_configuration.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/views/widget/widget.h"
namespace ash {
namespace {
const int kRootHeight = 600;
// A simple window delegate that returns the specified min size.
class TestWindowDelegate : public aura::test::TestWindowDelegate {
public:
TestWindowDelegate() = default;
~TestWindowDelegate() override = default;
void set_min_size(const gfx::Size& size) { min_size_ = size; }
void set_max_size(const gfx::Size& size) { max_size_ = size; }
private:
// Overridden from aura::Test::TestWindowDelegate:
gfx::Size GetMinimumSize() const override { return min_size_; }
gfx::Size GetMaximumSize() const override { return max_size_; }
gfx::Size min_size_;
gfx::Size max_size_;
DISALLOW_COPY_AND_ASSIGN(TestWindowDelegate);
};
// WindowState based on a given initial state. Records the last resize bounds.
class FakeWindowState : public wm::WindowState::State {
public:
explicit FakeWindowState(mojom::WindowStateType initial_state_type)
: state_type_(initial_state_type) {}
~FakeWindowState() override = default;
// WindowState::State overrides:
void OnWMEvent(wm::WindowState* window_state,
const wm::WMEvent* event) override {
if (event->IsBoundsEvent()) {
if (event->type() == wm::WM_EVENT_SET_BOUNDS) {
const auto* set_bounds_event =
static_cast<const wm::SetBoundsEvent*>(event);
last_bounds_ = set_bounds_event->requested_bounds();
}
}
}
mojom::WindowStateType GetType() const override { return state_type_; }
void AttachState(wm::WindowState* window_state,
wm::WindowState::State* previous_state) override {}
void DetachState(wm::WindowState* window_state) override {}
const gfx::Rect& last_bounds() { return last_bounds_; }
private:
mojom::WindowStateType state_type_;
gfx::Rect last_bounds_;
DISALLOW_COPY_AND_ASSIGN(FakeWindowState);
};
} // namespace
class WorkspaceWindowResizerTest : public AshTestBase {
public:
WorkspaceWindowResizerTest() : workspace_resizer_(nullptr) {}
~WorkspaceWindowResizerTest() override = default;
void SetUp() override {
AshTestBase::SetUp();
UpdateDisplay(base::StringPrintf("800x%d", kRootHeight));
// Ignore the touch slop region.
ui::GestureConfiguration::GetInstance()
->set_max_touch_move_in_pixels_for_click(0);
aura::Window* root = Shell::GetPrimaryRootWindow();
gfx::Rect root_bounds(root->bounds());
EXPECT_EQ(800, root_bounds.width());
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
window_ = window_factory::NewWindow(&delegate_);
window_->SetType(aura::client::WINDOW_TYPE_NORMAL);
window_->Init(ui::LAYER_NOT_DRAWN);
ParentWindowInPrimaryRootWindow(window_.get());
window_->set_id(1);
window2_ = window_factory::NewWindow(&delegate2_);
window2_->SetType(aura::client::WINDOW_TYPE_NORMAL);
window2_->Init(ui::LAYER_NOT_DRAWN);
ParentWindowInPrimaryRootWindow(window2_.get());
window2_->set_id(2);
window3_ = window_factory::NewWindow(&delegate3_);
window3_->SetType(aura::client::WINDOW_TYPE_NORMAL);
window3_->Init(ui::LAYER_NOT_DRAWN);
ParentWindowInPrimaryRootWindow(window3_.get());
window3_->set_id(3);
window4_ = window_factory::NewWindow(&delegate4_);
window4_->SetType(aura::client::WINDOW_TYPE_NORMAL);
window4_->Init(ui::LAYER_NOT_DRAWN);
ParentWindowInPrimaryRootWindow(window4_.get());
window4_->set_id(4);
}
void TearDown() override {
window_.reset();
window2_.reset();
window3_.reset();
window4_.reset();
touch_resize_window_.reset();
AshTestBase::TearDown();
}
// Returns a string identifying the z-order of each of the known child windows
// of |parent|. The returned string constains the id of the known windows and
// is ordered from topmost to bottomost windows.
std::string WindowOrderAsString(aura::Window* parent) const {
std::string result;
const aura::Window::Windows& windows = parent->children();
for (aura::Window::Windows::const_reverse_iterator i = windows.rbegin();
i != windows.rend(); ++i) {
if (*i == window_.get() || *i == window2_.get() || *i == window3_.get()) {
if (!result.empty())
result += " ";
result += base::IntToString((*i)->id());
}
}
return result;
}
protected:
WindowResizer* CreateResizerForTest(aura::Window* window,
const gfx::Point& point_in_parent,
int window_component) {
WindowResizer* resizer =
CreateWindowResizer(window, point_in_parent, window_component,
::wm::WINDOW_MOVE_SOURCE_MOUSE)
.release();
workspace_resizer_ = WorkspaceWindowResizer::GetInstanceForTest();
return resizer;
}
WorkspaceWindowResizer* CreateWorkspaceResizerForTest(
aura::Window* window,
const gfx::Point& point_in_parent,
int window_component,
::wm::WindowMoveSource source,
const std::vector<aura::Window*>& attached_windows) {
wm::WindowState* window_state = wm::GetWindowState(window);
window_state->CreateDragDetails(point_in_parent, window_component, source);
return WorkspaceWindowResizer::Create(window_state, attached_windows);
}
PhantomWindowController* snap_phantom_window_controller() const {
return workspace_resizer_->snap_phantom_window_controller_.get();
}
gfx::Point CalculateDragPoint(const WindowResizer& resizer,
int delta_x,
int delta_y) const {
gfx::Point location = resizer.GetInitialLocation();
location.set_x(location.x() + delta_x);
location.set_y(location.y() + delta_y);
return location;
}
std::vector<aura::Window*> empty_windows() const {
return std::vector<aura::Window*>();
}
void InitTouchResizeWindow(const gfx::Rect& bounds, int window_component) {
touch_resize_delegate_.set_window_component(window_component);
touch_resize_window_.reset(CreateTestWindowInShellWithDelegate(
&touch_resize_delegate_, 0, bounds));
}
TestWindowDelegate delegate_;
TestWindowDelegate delegate2_;
TestWindowDelegate delegate3_;
TestWindowDelegate delegate4_;
std::unique_ptr<aura::Window> window_;
std::unique_ptr<aura::Window> window2_;
std::unique_ptr<aura::Window> window3_;
std::unique_ptr<aura::Window> window4_;
TestWindowDelegate touch_resize_delegate_;
std::unique_ptr<aura::Window> touch_resize_window_;
WorkspaceWindowResizer* workspace_resizer_;
private:
DISALLOW_COPY_AND_ASSIGN(WorkspaceWindowResizerTest);
};
// Assertions around attached window resize dragging from the right with 2
// windows.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_RIGHT_2) {
window_->SetBounds(gfx::Rect(0, 300, 400, 300));
window2_->SetBounds(gfx::Rect(400, 200, 100, 200));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 to the right, which should expand w1 and push w2.
resizer->Drag(CalculateDragPoint(*resizer, 100, 10), 0);
EXPECT_EQ("0,300 500x300", window_->bounds().ToString());
EXPECT_EQ("500,200 100x200", window2_->bounds().ToString());
// Push off the screen, w2 should be resized to its min.
delegate2_.set_min_size(gfx::Size(20, 20));
resizer->Drag(CalculateDragPoint(*resizer, 800, 20), 0);
EXPECT_EQ("0,300 780x300", window_->bounds().ToString());
EXPECT_EQ("780,200 20x200", window2_->bounds().ToString());
// Move back to 100 and verify w2 gets its original size.
resizer->Drag(CalculateDragPoint(*resizer, 100, 10), 0);
EXPECT_EQ("0,300 500x300", window_->bounds().ToString());
EXPECT_EQ("500,200 100x200", window2_->bounds().ToString());
// Revert and make sure everything moves back.
resizer->Drag(CalculateDragPoint(*resizer, 800, 20), 0);
resizer->RevertDrag();
EXPECT_EQ("0,300 400x300", window_->bounds().ToString());
EXPECT_EQ("400,200 100x200", window2_->bounds().ToString());
}
// Assertions around collapsing and expanding.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_RIGHT_Compress) {
window_->SetBounds(gfx::Rect(0, 300, 400, 300));
window2_->SetBounds(gfx::Rect(400, 200, 100, 200));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 to the left, which should expand w2 and collapse w1.
resizer->Drag(CalculateDragPoint(*resizer, -100, 10), 0);
EXPECT_EQ("0,300 300x300", window_->bounds().ToString());
EXPECT_EQ("300,200 200x200", window2_->bounds().ToString());
// Collapse all the way to w1's min.
delegate_.set_min_size(gfx::Size(25, 25));
resizer->Drag(CalculateDragPoint(*resizer, -800, 25), 0);
EXPECT_EQ("0,300 25x300", window_->bounds().ToString());
EXPECT_EQ("25,200 475x200", window2_->bounds().ToString());
// But should keep minimum visible width;
resizer->Drag(CalculateDragPoint(*resizer, -800, 20), 0);
EXPECT_EQ("0,300 25x300", window_->bounds().ToString());
EXPECT_EQ("25,200 475x200", window2_->bounds().ToString());
// Move 100 to the left.
resizer->Drag(CalculateDragPoint(*resizer, 100, 10), 0);
EXPECT_EQ("0,300 500x300", window_->bounds().ToString());
EXPECT_EQ("500,200 100x200", window2_->bounds().ToString());
// Back to -100.
resizer->Drag(CalculateDragPoint(*resizer, -100, 20), 0);
EXPECT_EQ("0,300 300x300", window_->bounds().ToString());
EXPECT_EQ("300,200 200x200", window2_->bounds().ToString());
}
// Assertions around attached window resize dragging from the right with 3
// windows.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_RIGHT_3) {
window_->SetBounds(gfx::Rect(100, 300, 200, 300));
window2_->SetBounds(gfx::Rect(300, 300, 150, 200));
window3_->SetBounds(gfx::Rect(450, 300, 100, 200));
delegate2_.set_min_size(gfx::Size(52, 50));
delegate3_.set_min_size(gfx::Size(38, 50));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 to the right, which should expand w1 and push w2 and w3.
resizer->Drag(CalculateDragPoint(*resizer, 100, -10), 0);
EXPECT_EQ("100,300 300x300", window_->bounds().ToString());
EXPECT_EQ("400,300 150x200", window2_->bounds().ToString());
EXPECT_EQ("550,300 100x200", window3_->bounds().ToString());
// Move it 300, things should compress.
resizer->Drag(CalculateDragPoint(*resizer, 300, -10), 0);
EXPECT_EQ("100,300 500x300", window_->bounds().ToString());
EXPECT_EQ("600,300 120x200", window2_->bounds().ToString());
EXPECT_EQ("720,300 80x200", window3_->bounds().ToString());
// Move it so much the last two end up at their min.
resizer->Drag(CalculateDragPoint(*resizer, 800, 50), 0);
EXPECT_EQ("100,300 610x300", window_->bounds().ToString());
EXPECT_EQ("710,300 52x200", window2_->bounds().ToString());
EXPECT_EQ("762,300 38x200", window3_->bounds().ToString());
// Revert and make sure everything moves back.
resizer->RevertDrag();
EXPECT_EQ("100,300 200x300", window_->bounds().ToString());
EXPECT_EQ("300,300 150x200", window2_->bounds().ToString());
EXPECT_EQ("450,300 100x200", window3_->bounds().ToString());
}
// Assertions around attached window resizing (collapsing and expanding) with
// 3 windows.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_RIGHT_3_Compress) {
window_->SetBounds(gfx::Rect(100, 300, 200, 300));
window2_->SetBounds(gfx::Rect(300, 300, 200, 200));
window3_->SetBounds(gfx::Rect(450, 300, 100, 200));
delegate2_.set_min_size(gfx::Size(52, 50));
delegate3_.set_min_size(gfx::Size(38, 50));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it -100 to the right, which should collapse w1 and expand w2 and w3.
resizer->Drag(CalculateDragPoint(*resizer, -100, -10), 0);
EXPECT_EQ("100,300 100x300", window_->bounds().ToString());
EXPECT_EQ("200,300 266x200", window2_->bounds().ToString());
EXPECT_EQ("466,300 134x200", window3_->bounds().ToString());
// Move it 100 to the right.
resizer->Drag(CalculateDragPoint(*resizer, 100, -10), 0);
EXPECT_EQ("100,300 300x300", window_->bounds().ToString());
EXPECT_EQ("400,300 200x200", window2_->bounds().ToString());
EXPECT_EQ("600,300 100x200", window3_->bounds().ToString());
// 100 to the left again.
resizer->Drag(CalculateDragPoint(*resizer, -100, -10), 0);
EXPECT_EQ("100,300 100x300", window_->bounds().ToString());
EXPECT_EQ("200,300 266x200", window2_->bounds().ToString());
EXPECT_EQ("466,300 134x200", window3_->bounds().ToString());
}
// Assertions around collapsing and expanding from the bottom.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_BOTTOM_Compress) {
window_->SetBounds(gfx::Rect(0, 100, 400, 300));
window2_->SetBounds(gfx::Rect(400, 400, 100, 200));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTBOTTOM,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it up 100, which should expand w2 and collapse w1.
resizer->Drag(CalculateDragPoint(*resizer, 10, -100), 0);
EXPECT_EQ("0,100 400x200", window_->bounds().ToString());
EXPECT_EQ("400,300 100x300", window2_->bounds().ToString());
// Collapse all the way to w1's min.
delegate_.set_min_size(gfx::Size(20, 20));
resizer->Drag(CalculateDragPoint(*resizer, 20, -800), 0);
EXPECT_EQ("0,100 400x20", window_->bounds().ToString());
EXPECT_EQ("400,120 100x480", window2_->bounds().ToString());
// Move 100 down.
resizer->Drag(CalculateDragPoint(*resizer, 10, 100), 0);
EXPECT_EQ("0,100 400x400", window_->bounds().ToString());
EXPECT_EQ("400,500 100x100", window2_->bounds().ToString());
// Back to -100.
resizer->Drag(CalculateDragPoint(*resizer, 20, -100), 0);
EXPECT_EQ("0,100 400x200", window_->bounds().ToString());
EXPECT_EQ("400,300 100x300", window2_->bounds().ToString());
}
// Assertions around attached window resize dragging from the bottom with 2
// windows.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_BOTTOM_2) {
window_->SetBounds(gfx::Rect(0, 50, 400, 200));
window2_->SetBounds(gfx::Rect(0, 250, 200, 100));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTBOTTOM,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 to the bottom, which should expand w1 and push w2.
resizer->Drag(CalculateDragPoint(*resizer, 10, 100), 0);
EXPECT_EQ("0,50 400x300", window_->bounds().ToString());
EXPECT_EQ("0,350 200x100", window2_->bounds().ToString());
// Push off the screen, w2 should be resized to its min.
delegate2_.set_min_size(gfx::Size(20, 20));
resizer->Drag(CalculateDragPoint(*resizer, 50, 820), 0);
EXPECT_EQ("0,50 400x530", window_->bounds().ToString());
EXPECT_EQ("0,580 200x20", window2_->bounds().ToString());
// Move back to 100 and verify w2 gets its original size.
resizer->Drag(CalculateDragPoint(*resizer, 10, 100), 0);
EXPECT_EQ("0,50 400x300", window_->bounds().ToString());
EXPECT_EQ("0,350 200x100", window2_->bounds().ToString());
// Revert and make sure everything moves back.
resizer->Drag(CalculateDragPoint(*resizer, 800, 20), 0);
resizer->RevertDrag();
EXPECT_EQ("0,50 400x200", window_->bounds().ToString());
EXPECT_EQ("0,250 200x100", window2_->bounds().ToString());
}
// Assertions around attached window resize dragging from the bottom with 3
// windows.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_BOTTOM_3) {
UpdateDisplay("600x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
window_->SetBounds(gfx::Rect(300, 100, 300, 200));
window2_->SetBounds(gfx::Rect(300, 300, 200, 150));
window3_->SetBounds(gfx::Rect(300, 450, 200, 100));
delegate2_.set_min_size(gfx::Size(50, 52));
delegate3_.set_min_size(gfx::Size(50, 38));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTBOTTOM,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 down, which should expand w1 and push w2 and w3.
resizer->Drag(CalculateDragPoint(*resizer, -10, 100), 0);
EXPECT_EQ("300,100 300x300", window_->bounds().ToString());
EXPECT_EQ("300,400 200x150", window2_->bounds().ToString());
EXPECT_EQ("300,550 200x100", window3_->bounds().ToString());
// Move it 296 things should compress.
resizer->Drag(CalculateDragPoint(*resizer, -10, 296), 0);
EXPECT_EQ("300,100 300x496", window_->bounds().ToString());
EXPECT_EQ("300,596 200x123", window2_->bounds().ToString());
EXPECT_EQ("300,719 200x81", window3_->bounds().ToString());
// Move it so much everything ends up at its min.
resizer->Drag(CalculateDragPoint(*resizer, 50, 798), 0);
EXPECT_EQ("300,100 300x610", window_->bounds().ToString());
EXPECT_EQ("300,710 200x52", window2_->bounds().ToString());
EXPECT_EQ("300,762 200x38", window3_->bounds().ToString());
// Revert and make sure everything moves back.
resizer->RevertDrag();
EXPECT_EQ("300,100 300x200", window_->bounds().ToString());
EXPECT_EQ("300,300 200x150", window2_->bounds().ToString());
EXPECT_EQ("300,450 200x100", window3_->bounds().ToString());
}
// Assertions around attached window resizing (collapsing and expanding) with
// 3 windows.
TEST_F(WorkspaceWindowResizerTest, AttachedResize_BOTTOM_3_Compress) {
window_->SetBounds(gfx::Rect(0, 0, 200, 200));
window2_->SetBounds(gfx::Rect(10, 200, 200, 200));
window3_->SetBounds(gfx::Rect(20, 400, 100, 100));
delegate2_.set_min_size(gfx::Size(52, 50));
delegate3_.set_min_size(gfx::Size(38, 50));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTBOTTOM,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 up, which should collapse w1 and expand w2 and w3.
resizer->Drag(CalculateDragPoint(*resizer, -10, -100), 0);
EXPECT_EQ("0,0 200x100", window_->bounds().ToString());
EXPECT_EQ("10,100 200x266", window2_->bounds().ToString());
EXPECT_EQ("20,366 100x134", window3_->bounds().ToString());
// Move it 100 down.
resizer->Drag(CalculateDragPoint(*resizer, 10, 100), 0);
EXPECT_EQ("0,0 200x300", window_->bounds().ToString());
EXPECT_EQ("10,300 200x200", window2_->bounds().ToString());
EXPECT_EQ("20,500 100x100", window3_->bounds().ToString());
// 100 up again.
resizer->Drag(CalculateDragPoint(*resizer, -10, -100), 0);
EXPECT_EQ("0,0 200x100", window_->bounds().ToString());
EXPECT_EQ("10,100 200x266", window2_->bounds().ToString());
EXPECT_EQ("20,366 100x134", window3_->bounds().ToString());
}
// Tests that touch-dragging a window does not lock the mouse cursor
// and therefore shows the cursor on a mousemove.
TEST_F(WorkspaceWindowResizerTest, MouseMoveWithTouchDrag) {
// Shell hides the cursor by default; show it for this tests.
Shell::Get()->cursor_manager()->ShowCursor();
window_->SetBounds(gfx::Rect(0, 300, 400, 300));
window2_->SetBounds(gfx::Rect(400, 200, 100, 200));
Shell* shell = Shell::Get();
ui::test::EventGenerator generator(window_->GetRootWindow());
// The cursor should not be locked initially.
EXPECT_FALSE(shell->cursor_manager()->IsCursorLocked());
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_TOUCH, windows));
ASSERT_TRUE(resizer.get());
// Creating a WorkspaceWindowResizer should not lock the cursor.
EXPECT_FALSE(shell->cursor_manager()->IsCursorLocked());
// The cursor should be hidden after touching the screen and
// starting a drag.
EXPECT_TRUE(shell->cursor_manager()->IsCursorVisible());
generator.PressTouch();
resizer->Drag(CalculateDragPoint(*resizer, 100, 10), 0);
EXPECT_FALSE(shell->cursor_manager()->IsCursorVisible());
EXPECT_FALSE(shell->cursor_manager()->IsCursorLocked());
// Moving the mouse should show the cursor.
generator.MoveMouseBy(1, 1);
EXPECT_TRUE(shell->cursor_manager()->IsCursorVisible());
EXPECT_FALSE(shell->cursor_manager()->IsCursorLocked());
resizer->RevertDrag();
}
// Assertions around dragging to the left/right edge of the screen.
TEST_F(WorkspaceWindowResizerTest, Edge) {
// Resize host window to force insets update.
UpdateDisplay("800x700");
// TODO(varkha): Insets are reset after every drag because of
// http://crbug.com/292238.
window_->SetBounds(gfx::Rect(20, 30, 400, 60));
window_->SetProperty(aura::client::kResizeBehaviorKey,
ui::mojom::kResizeBehaviorCanResize |
ui::mojom::kResizeBehaviorCanMaximize);
wm::WindowState* window_state = wm::GetWindowState(window_.get());
{
gfx::Rect expected_bounds_in_parent(
wm::GetDefaultLeftSnappedWindowBoundsInParent(window_.get()));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 10), 0);
resizer->CompleteDrag();
EXPECT_EQ(expected_bounds_in_parent.ToString(),
window_->bounds().ToString());
ASSERT_TRUE(window_state->HasRestoreBounds());
EXPECT_EQ("20,30 400x60",
window_state->GetRestoreBoundsInScreen().ToString());
}
// Try the same with the right side.
{
gfx::Rect expected_bounds_in_parent(
wm::GetDefaultRightSnappedWindowBoundsInParent(window_.get()));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 800, 10), 0);
resizer->CompleteDrag();
EXPECT_EQ(expected_bounds_in_parent.ToString(),
window_->bounds().ToString());
ASSERT_TRUE(window_state->HasRestoreBounds());
EXPECT_EQ("20,30 400x60",
window_state->GetRestoreBoundsInScreen().ToString());
}
// Restore the window to clear snapped state.
window_state->Restore();
// Test if the restore bounds is correct in multiple displays.
UpdateDisplay("800x600,500x600");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
EXPECT_EQ(root_windows[0], window_->GetRootWindow());
window_->SetBoundsInScreen(gfx::Rect(800, 10, 400, 60),
GetSecondaryDisplay());
EXPECT_EQ(root_windows[1], window_->GetRootWindow());
{
EXPECT_EQ("800,10 400x60", window_->GetBoundsInScreen().ToString());
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 499, 0), 0);
int bottom =
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()).bottom();
resizer->CompleteDrag();
// With the resolution of 500x600 we will hit in this case the 50% screen
// size setting.
// TODO(varkha): Insets are updated because of http://crbug.com/292238
EXPECT_EQ("250,0 250x" + base::IntToString(bottom),
window_->bounds().ToString());
EXPECT_EQ("800,10 400x60",
window_state->GetRestoreBoundsInScreen().ToString());
}
}
// Check that non resizable windows will not get resized.
TEST_F(WorkspaceWindowResizerTest, NonResizableWindows) {
window_->SetBounds(gfx::Rect(20, 30, 50, 60));
window_->SetProperty(aura::client::kResizeBehaviorKey,
ui::mojom::kResizeBehaviorNone);
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, -20, 0), 0);
resizer->CompleteDrag();
EXPECT_EQ("0,30 50x60", window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, CancelSnapPhantom) {
UpdateDisplay("800x600,800x600");
aura::Window::Windows root_windows = Shell::GetAllRootWindows();
ASSERT_EQ(2U, root_windows.size());
window_->SetBoundsInScreen(gfx::Rect(0, 0, 50, 60),
display::Screen::GetScreen()->GetPrimaryDisplay());
// Make the window snappable by making it resizable and maximizable.
window_->SetProperty(aura::client::kResizeBehaviorKey,
ui::mojom::kResizeBehaviorCanResize |
ui::mojom::kResizeBehaviorCanMaximize);
EXPECT_EQ(root_windows[0], window_->GetRootWindow());
EXPECT_FLOAT_EQ(1.0f, window_->layer()->opacity());
{
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
EXPECT_FALSE(snap_phantom_window_controller());
// The pointer is on the edge but not shared. The snap phantom window
// controller should be non-NULL.
resizer->Drag(CalculateDragPoint(*resizer, 799, 0), 0);
EXPECT_TRUE(snap_phantom_window_controller());
// Move the cursor across the edge. Now the snap phantom window controller
// should be canceled.
resizer->Drag(CalculateDragPoint(*resizer, 800, 0), 0);
EXPECT_FALSE(snap_phantom_window_controller());
}
}
// Verifies that dragging a snapped window unsnaps it.
TEST_F(WorkspaceWindowResizerTest, DragSnapped) {
wm::WindowState* window_state = ash::wm::GetWindowState(window_.get());
const gfx::Rect kInitialBounds(100, 100, 100, 100);
window_->SetBounds(kInitialBounds);
window_->Show();
const wm::WMEvent snap_event(wm::WM_EVENT_SNAP_LEFT);
window_state->OnWMEvent(&snap_event);
EXPECT_EQ(mojom::WindowStateType::LEFT_SNAPPED, window_state->GetStateType());
gfx::Rect snapped_bounds = window_->bounds();
EXPECT_NE(snapped_bounds.ToString(), kInitialBounds.ToString());
EXPECT_EQ(window_state->GetRestoreBoundsInParent().ToString(),
kInitialBounds.ToString());
// Dragging a side snapped window should unsnap it.
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
resizer->Drag(CalculateDragPoint(*resizer, 10, 0), 0);
resizer->CompleteDrag();
EXPECT_EQ(mojom::WindowStateType::NORMAL, window_state->GetStateType());
EXPECT_EQ("10,0 100x100", window_->bounds().ToString());
EXPECT_FALSE(window_state->HasRestoreBounds());
}
// Verifies the behavior of resizing a side snapped window.
TEST_F(WorkspaceWindowResizerTest, ResizeSnapped) {
wm::WindowState* window_state = ash::wm::GetWindowState(window_.get());
const gfx::Rect kInitialBounds(100, 100, 100, 100);
window_->SetBounds(kInitialBounds);
window_->Show();
const wm::WMEvent snap_event(wm::WM_EVENT_SNAP_LEFT);
window_state->OnWMEvent(&snap_event);
EXPECT_EQ(mojom::WindowStateType::LEFT_SNAPPED, window_state->GetStateType());
gfx::Rect snapped_bounds = window_->bounds();
EXPECT_NE(snapped_bounds.ToString(), kInitialBounds.ToString());
EXPECT_EQ(window_state->GetRestoreBoundsInParent().ToString(),
kInitialBounds.ToString());
{
// 1) Resizing a side snapped window to make it wider should not unsnap the
// window.
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTRIGHT));
resizer->Drag(CalculateDragPoint(*resizer, 10, 0), 0);
resizer->CompleteDrag();
EXPECT_EQ(mojom::WindowStateType::LEFT_SNAPPED,
window_state->GetStateType());
snapped_bounds.Inset(0, 0, -10, 0);
EXPECT_EQ(snapped_bounds.ToString(), window_->bounds().ToString());
EXPECT_EQ(window_state->GetRestoreBoundsInParent().ToString(),
kInitialBounds.ToString());
}
{
// 2) Resizing a side snapped window vertically and then undoing the change
// should not unsnap.
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOM));
resizer->Drag(CalculateDragPoint(*resizer, 0, -30), 0);
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
resizer->CompleteDrag();
EXPECT_EQ(mojom::WindowStateType::LEFT_SNAPPED,
window_state->GetStateType());
EXPECT_EQ(snapped_bounds.ToString(), window_->bounds().ToString());
EXPECT_EQ(window_state->GetRestoreBoundsInParent().ToString(),
kInitialBounds.ToString());
}
{
// 3) Resizing a side snapped window vertically and then not undoing the
// change should unsnap.
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOM));
resizer->Drag(CalculateDragPoint(*resizer, 0, -10), 0);
resizer->CompleteDrag();
EXPECT_EQ(mojom::WindowStateType::NORMAL, window_state->GetStateType());
gfx::Rect expected_bounds(snapped_bounds);
expected_bounds.Inset(0, 0, 0, 10);
EXPECT_EQ(expected_bounds.ToString(), window_->bounds().ToString());
EXPECT_FALSE(window_state->HasRestoreBounds());
}
}
// Verifies windows are correctly restacked when reordering multiple windows.
TEST_F(WorkspaceWindowResizerTest, RestackAttached) {
window_->SetBounds(gfx::Rect(0, 0, 200, 300));
window2_->SetBounds(gfx::Rect(200, 0, 100, 200));
window3_->SetBounds(gfx::Rect(300, 0, 100, 100));
{
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 to the right, which should expand w1 and push w2 and w3.
resizer->Drag(CalculateDragPoint(*resizer, 100, -10), 0);
// 2 should be topmost since it's initially the highest in the stack.
EXPECT_EQ("2 1 3", WindowOrderAsString(window_->parent()));
}
{
std::vector<aura::Window*> windows;
windows.push_back(window3_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window2_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 100 to the right, which should expand w1 and push w2 and w3.
resizer->Drag(CalculateDragPoint(*resizer, 100, -10), 0);
// 2 should be topmost since it's initially the highest in the stack.
EXPECT_EQ("2 3 1", WindowOrderAsString(window_->parent()));
}
}
// Makes sure we don't allow dragging below the work area.
TEST_F(WorkspaceWindowResizerTest, DontDragOffBottom) {
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 10, 0));
ASSERT_EQ(1, display::Screen::GetScreen()->GetNumDisplays());
window_->SetBounds(gfx::Rect(100, 200, 300, 400));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 600), 0);
int expected_y =
kRootHeight - WorkspaceWindowResizer::kMinOnscreenHeight - 10;
EXPECT_EQ("100," + base::IntToString(expected_y) + " 300x400",
window_->bounds().ToString());
}
// Makes sure we don't allow dragging on the work area with multidisplay.
TEST_F(WorkspaceWindowResizerTest, DontDragOffBottomWithMultiDisplay) {
UpdateDisplay("800x600,800x600");
ASSERT_EQ(2, display::Screen::GetScreen()->GetNumDisplays());
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 10, 0));
// Positions the secondary display at the bottom the primary display.
Shell::Get()->display_manager()->SetLayoutForCurrentDisplays(
display::test::CreateDisplayLayout(display_manager(),
display::DisplayPlacement::BOTTOM, 0));
{
window_->SetBounds(gfx::Rect(100, 200, 300, 20));
DCHECK_LT(window_->bounds().height(),
WorkspaceWindowResizer::kMinOnscreenHeight);
// Drag down avoiding dragging along the edge as that would side-snap.
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(10, 0), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 400), 0);
int expected_y = kRootHeight - window_->bounds().height() - 10;
// When the mouse cursor is in the primary display, the window cannot move
// on non-work area but can get all the way towards the bottom,
// restricted only by the window height.
EXPECT_EQ("100," + base::IntToString(expected_y) + " 300x20",
window_->bounds().ToString());
// Revert the drag in order to not remember the restore bounds.
resizer->RevertDrag();
}
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 10, 0));
{
window_->SetBounds(gfx::Rect(100, 200, 300, 400));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(10, 0), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Drag down avoiding dragging along the edge as that would side-snap.
resizer->Drag(CalculateDragPoint(*resizer, 0, 400), 0);
int expected_y =
kRootHeight - WorkspaceWindowResizer::kMinOnscreenHeight - 10;
// When the mouse cursor is in the primary display, the window cannot move
// on non-work area with kMinOnscreenHeight margin.
EXPECT_EQ("100," + base::IntToString(expected_y) + " 300x400",
window_->bounds().ToString());
resizer->CompleteDrag();
}
{
window_->SetBounds(gfx::Rect(100, 200, 300, 400));
std::unique_ptr<WindowResizer> resizer(CreateResizerForTest(
window_.get(), window_->bounds().origin(), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Drag down avoiding getting stuck against the shelf on the bottom screen.
resizer->Drag(CalculateDragPoint(*resizer, 0, 500), 0);
// The window can move to the secondary display beyond non-work area of
// the primary display.
EXPECT_EQ("100,700 300x400", window_->bounds().ToString());
resizer->CompleteDrag();
}
}
// Makes sure we don't allow dragging off the top of the work area.
TEST_F(WorkspaceWindowResizerTest, DontDragOffTop) {
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(10, 0, 0, 0));
window_->SetBounds(gfx::Rect(100, 200, 300, 400));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, -600), 0);
EXPECT_EQ("100,10 300x400", window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, ResizeBottomOutsideWorkArea) {
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 50, 0));
window_->SetBounds(gfx::Rect(100, 200, 300, 380));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOP));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 8, 0), 0);
EXPECT_EQ("100,200 300x380", window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, ResizeWindowOutsideLeftWorkArea) {
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 50, 0));
int left = screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()).x();
int pixels_to_left_border = 50;
int window_width = 300;
int window_x = left - window_width + pixels_to_left_border;
window_->SetBounds(gfx::Rect(window_x, 100, window_width, 380));
std::unique_ptr<WindowResizer> resizer(CreateResizerForTest(
window_.get(), gfx::Point(pixels_to_left_border, 0), HTRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, -window_width, 0), 0);
EXPECT_EQ(base::IntToString(window_x) + ",100 " +
base::IntToString(wm::kMinimumOnScreenArea - window_x) + "x380",
window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, ResizeWindowOutsideRightWorkArea) {
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 50, 0));
int right =
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()).right();
int pixels_to_right_border = 50;
int window_width = 300;
int window_x = right - pixels_to_right_border;
window_->SetBounds(gfx::Rect(window_x, 100, window_width, 380));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(window_x, 0), HTLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, window_width, 0), 0);
EXPECT_EQ(base::IntToString(right - wm::kMinimumOnScreenArea) + ",100 " +
base::IntToString(window_width - pixels_to_right_border +
wm::kMinimumOnScreenArea) +
"x380",
window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, ResizeWindowOutsideBottomWorkArea) {
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 50, 0));
int bottom =
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()).bottom();
int delta_to_bottom = 50;
int height = 380;
window_->SetBounds(gfx::Rect(100, bottom - delta_to_bottom, 300, height));
std::unique_ptr<WindowResizer> resizer(CreateResizerForTest(
window_.get(), gfx::Point(0, bottom - delta_to_bottom), HTTOP));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, bottom), 0);
EXPECT_EQ("100," + base::IntToString(bottom - wm::kMinimumOnScreenArea) +
" 300x" +
base::IntToString(height -
(delta_to_bottom - wm::kMinimumOnScreenArea)),
window_->bounds().ToString());
}
// Verifies that 'outside' check of the resizer take into account the extended
// desktop in case of repositions.
TEST_F(WorkspaceWindowResizerTest, DragWindowOutsideRightToSecondaryDisplay) {
// Only primary display. Changes the window position to fit within the
// display.
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 50, 0));
int right =
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()).right();
int pixels_to_right_border = 50;
int window_width = 300;
int window_x = right - pixels_to_right_border;
window_->SetBounds(gfx::Rect(window_x, 100, window_width, 380));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(window_x, 0), HTCAPTION));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, window_width, 0), 0);
EXPECT_EQ(base::IntToString(right - wm::kMinimumOnScreenArea) + ",100 " +
base::IntToString(window_width) + "x380",
window_->bounds().ToString());
// With secondary display. Operation itself is same but doesn't change
// the position because the window is still within the secondary display.
UpdateDisplay("1000x600,600x400");
Shell::Get()->SetDisplayWorkAreaInsets(Shell::GetPrimaryRootWindow(),
gfx::Insets(0, 0, 50, 0));
window_->SetBounds(gfx::Rect(window_x, 100, window_width, 380));
resizer->Drag(CalculateDragPoint(*resizer, window_width, 0), 0);
EXPECT_EQ(base::IntToString(window_x + window_width) + ",100 " +
base::IntToString(window_width) + "x380",
window_->bounds().ToString());
}
// Verifies snapping to edges works.
TEST_F(WorkspaceWindowResizerTest, SnapToEdge) {
GetPrimaryShelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS);
window_->SetBounds(gfx::Rect(96, 112, 320, 160));
// Click 50px to the right so that the mouse pointer does not leave the
// workspace ensuring sticky behavior.
std::unique_ptr<WindowResizer> resizer(CreateResizerForTest(
window_.get(), window_->bounds().origin() + gfx::Vector2d(50, 0),
HTCAPTION));
ASSERT_TRUE(resizer.get());
int distance_to_left = window_->bounds().x();
int distance_to_right =
800 - window_->bounds().width() - window_->bounds().x();
int distance_to_bottom =
600 - window_->bounds().height() - window_->bounds().y();
int distance_to_top = window_->bounds().y();
// Test left side.
// Move to an x-coordinate of 15, which should not snap.
resizer->Drag(CalculateDragPoint(*resizer, 15 - distance_to_left, 0), 0);
// An x-coordinate of 7 should snap.
resizer->Drag(CalculateDragPoint(*resizer, 7 - distance_to_left, 0), 0);
EXPECT_EQ("0,112 320x160", window_->bounds().ToString());
// Move to -15, should still snap to 0.
resizer->Drag(CalculateDragPoint(*resizer, -15 - distance_to_left, 0), 0);
EXPECT_EQ("0,112 320x160", window_->bounds().ToString());
// At -32 should move past snap points.
resizer->Drag(CalculateDragPoint(*resizer, -32 - distance_to_left, 0), 0);
EXPECT_EQ("-32,112 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, -33 - distance_to_left, 0), 0);
EXPECT_EQ("-33,112 320x160", window_->bounds().ToString());
// Right side should similarly snap.
resizer->Drag(CalculateDragPoint(*resizer, distance_to_right - 15, 0), 0);
EXPECT_EQ("465,112 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, distance_to_right - 7, 0), 0);
EXPECT_EQ("480,112 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, distance_to_right + 15, 0), 0);
EXPECT_EQ("480,112 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, distance_to_right + 32, 0), 0);
EXPECT_EQ("512,112 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, distance_to_right + 33, 0), 0);
EXPECT_EQ("513,112 320x160", window_->bounds().ToString());
// And the bottom should snap too.
resizer->Drag(CalculateDragPoint(*resizer, 0, distance_to_bottom - 7), 0);
EXPECT_EQ(gfx::Rect(96, 440, 320, 160).ToString(),
window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, 0, distance_to_bottom + 15), 0);
EXPECT_EQ(gfx::Rect(96, 440, 320, 160).ToString(),
window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, 0, distance_to_bottom - 2 + 32),
0);
EXPECT_EQ("96,470 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, 0, distance_to_bottom - 2 + 33),
0);
EXPECT_EQ("96,471 320x160", window_->bounds().ToString());
// And the top should snap too.
resizer->Drag(CalculateDragPoint(*resizer, 0, -distance_to_top + 20), 0);
EXPECT_EQ("96,20 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, 0, -distance_to_top + 7), 0);
EXPECT_EQ("96,0 320x160", window_->bounds().ToString());
// And bottom/left should snap too.
resizer->Drag(CalculateDragPoint(*resizer, 7 - distance_to_left,
distance_to_bottom - 7),
0);
EXPECT_EQ(gfx::Rect(0, 440, 320, 160).ToString(),
window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, -15 - distance_to_left,
distance_to_bottom + 15),
0);
EXPECT_EQ(gfx::Rect(0, 440, 320, 160).ToString(),
window_->bounds().ToString());
// should move past snap points.
resizer->Drag(CalculateDragPoint(*resizer, -32 - distance_to_left,
distance_to_bottom - 2 + 32),
0);
EXPECT_EQ("-32,470 320x160", window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, -33 - distance_to_left,
distance_to_bottom - 2 + 33),
0);
EXPECT_EQ("-33,471 320x160", window_->bounds().ToString());
// No need to test dragging < 0 as we force that to 0.
}
// Verifies a resize snap when dragging TOPLEFT.
TEST_F(WorkspaceWindowResizerTest, SnapToWorkArea_TOPLEFT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOPLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, -98, -199), 0);
EXPECT_EQ("0,0 120x230", window_->bounds().ToString());
}
// Verifies a resize snap when dragging TOPRIGHT.
TEST_F(WorkspaceWindowResizerTest, SnapToWorkArea_TOPRIGHT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
gfx::Rect work_area(
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOPRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, work_area.right() - 120 - 1, -199),
0);
EXPECT_EQ(100, window_->bounds().x());
EXPECT_EQ(work_area.y(), window_->bounds().y());
EXPECT_EQ(work_area.right() - 100, window_->bounds().width());
EXPECT_EQ(230, window_->bounds().height());
}
// Verifies a resize snap when dragging BOTTOMRIGHT.
TEST_F(WorkspaceWindowResizerTest, SnapToWorkArea_BOTTOMRIGHT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
gfx::Rect work_area(
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, work_area.right() - 120 - 1,
work_area.bottom() - 220 - 2),
0);
EXPECT_EQ(100, window_->bounds().x());
EXPECT_EQ(200, window_->bounds().y());
EXPECT_EQ(work_area.right() - 100, window_->bounds().width());
EXPECT_EQ(work_area.bottom() - 200, window_->bounds().height());
}
// Verifies a resize snap when dragging BOTTOMLEFT.
TEST_F(WorkspaceWindowResizerTest, SnapToWorkArea_BOTTOMLEFT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
gfx::Rect work_area(
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, -98, work_area.bottom() - 220 - 2),
0);
EXPECT_EQ(0, window_->bounds().x());
EXPECT_EQ(200, window_->bounds().y());
EXPECT_EQ(120, window_->bounds().width());
EXPECT_EQ(work_area.bottom() - 200, window_->bounds().height());
}
// Verifies window sticks to both window and work area.
TEST_F(WorkspaceWindowResizerTest, StickToBothEdgeAndWindow) {
window_->SetBounds(gfx::Rect(10, 10, 20, 50));
window_->Show();
window2_->SetBounds(gfx::Rect(150, 160, 25, 1000));
window2_->Show();
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(10, 10), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Move |window| one pixel to the left of |window2|. Should snap to right.
resizer->Drag(CalculateDragPoint(*resizer, 119, 145), 0);
gfx::Rect expected(130, 160, 20, 50);
EXPECT_EQ(expected.ToString(), window_->bounds().ToString());
gfx::Rect work_area(
screen_util::GetDisplayWorkAreaBoundsInParent(window_.get()));
// The initial y position of |window_|.
int initial_y = 10;
// The drag position where the window is exactly attached to the bottom.
int attach_y = work_area.bottom() - window_->bounds().height() - initial_y;
// Dragging 10px above should not attach to the bottom.
resizer->Drag(CalculateDragPoint(*resizer, 119, attach_y - 10), 0);
expected.set_y(attach_y + initial_y - 10);
EXPECT_EQ(expected.ToString(), window_->bounds().ToString());
// Stick to the work area.
resizer->Drag(CalculateDragPoint(*resizer, 119, attach_y - 1), 0);
expected.set_y(attach_y + initial_y);
EXPECT_EQ(expected.ToString(), window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, 119, attach_y), 0);
expected.set_y(attach_y + initial_y);
EXPECT_EQ(expected.ToString(), window_->bounds().ToString());
resizer->Drag(CalculateDragPoint(*resizer, 119, attach_y + 1), 0);
expected.set_y(attach_y + initial_y);
EXPECT_EQ(expected.ToString(), window_->bounds().ToString());
// Moving down further should move the window.
resizer->Drag(CalculateDragPoint(*resizer, 119, attach_y + 18), 0);
expected.set_y(attach_y + initial_y + 18);
EXPECT_EQ(expected.ToString(), window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, CtrlDragResizeToExactPosition) {
window_->SetBounds(gfx::Rect(96, 112, 320, 160));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMRIGHT));
ASSERT_TRUE(resizer.get());
// Resize the right bottom to add 10 in width, 12 in height.
resizer->Drag(CalculateDragPoint(*resizer, 10, 12), ui::EF_CONTROL_DOWN);
// Both bottom and right sides to resize to exact size requested.
EXPECT_EQ("96,112 330x172", window_->bounds().ToString());
}
// Verifies that a dragged, non-snapped window will clear restore bounds.
TEST_F(WorkspaceWindowResizerTest, RestoreClearedOnResize) {
window_->SetBounds(gfx::Rect(10, 10, 100, 100));
wm::WindowState* window_state = wm::GetWindowState(window_.get());
window_state->SetRestoreBoundsInScreen(gfx::Rect(50, 50, 50, 50));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMRIGHT));
ASSERT_TRUE(resizer.get());
// Drag the window to new position by adding (20, 30) to original point,
// the original restore bound should be cleared.
resizer->Drag(CalculateDragPoint(*resizer, 20, 30), 0);
resizer->CompleteDrag();
EXPECT_EQ("10,10 120x130", window_->bounds().ToString());
EXPECT_FALSE(window_state->HasRestoreBounds());
}
// Verifies that a dragged window will restore to its pre-maximized size.
TEST_F(WorkspaceWindowResizerTest, RestoreToPreMaximizeCoordinates) {
window_->SetBounds(gfx::Rect(0, 0, 1000, 1000));
wm::WindowState* window_state = wm::GetWindowState(window_.get());
window_state->SetRestoreBoundsInScreen(gfx::Rect(96, 112, 320, 160));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Drag the window to new position by adding (10, 10) to original point,
// the window should get restored.
resizer->Drag(CalculateDragPoint(*resizer, 10, 10), 0);
resizer->CompleteDrag();
EXPECT_EQ("10,10 320x160", window_->bounds().ToString());
// The restore rectangle should get cleared as well.
EXPECT_FALSE(window_state->HasRestoreBounds());
}
// Verifies that a dragged window will restore to its pre-maximized size.
TEST_F(WorkspaceWindowResizerTest, RevertResizeOperation) {
const gfx::Rect initial_bounds(0, 0, 200, 400);
window_->SetBounds(initial_bounds);
wm::WindowState* window_state = wm::GetWindowState(window_.get());
window_state->SetRestoreBoundsInScreen(gfx::Rect(96, 112, 320, 160));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Drag the window to new poistion by adding (180, 16) to original point,
// the window should get restored.
resizer->Drag(CalculateDragPoint(*resizer, 180, 16), 0);
resizer->RevertDrag();
EXPECT_EQ(initial_bounds.ToString(), window_->bounds().ToString());
EXPECT_EQ("96,112 320x160",
window_state->GetRestoreBoundsInScreen().ToString());
}
// Check that only usable sizes get returned by the resizer.
TEST_F(WorkspaceWindowResizerTest, MagneticallyAttach) {
window_->SetBounds(gfx::Rect(10, 10, 20, 30));
window2_->SetBounds(gfx::Rect(150, 160, 25, 20));
window2_->Show();
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Move |window| one pixel to the left of |window2|. Should snap to right and
// top.
resizer->Drag(CalculateDragPoint(*resizer, 119, 145), 0);
EXPECT_EQ("130,160 20x30", window_->bounds().ToString());
// Move |window| one pixel to the right of |window2|. Should snap to left and
// top.
resizer->Drag(CalculateDragPoint(*resizer, 164, 145), 0);
EXPECT_EQ("175,160 20x30", window_->bounds().ToString());
// Move |window| one pixel above |window2|. Should snap to top and left.
resizer->Drag(CalculateDragPoint(*resizer, 142, 119), 0);
EXPECT_EQ("150,130 20x30", window_->bounds().ToString());
// Move |window| one pixel above the bottom of |window2|. Should snap to
// bottom and left.
resizer->Drag(CalculateDragPoint(*resizer, 142, 169), 0);
EXPECT_EQ("150,180 20x30", window_->bounds().ToString());
}
// The following variants verify magnetic snapping during resize when dragging a
// particular edge.
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_TOP) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->SetBounds(gfx::Rect(99, 179, 10, 20));
window2_->Show();
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOP));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("100,199 20x31", window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_TOPLEFT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->SetBounds(gfx::Rect(99, 179, 10, 20));
window2_->Show();
{
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOPLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("99,199 21x31", window_->bounds().ToString());
resizer->RevertDrag();
}
{
window2_->SetBounds(gfx::Rect(88, 201, 10, 20));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOPLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("98,201 22x29", window_->bounds().ToString());
resizer->RevertDrag();
}
}
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_TOPRIGHT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->Show();
{
window2_->SetBounds(gfx::Rect(111, 179, 10, 20));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOPRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("100,199 21x31", window_->bounds().ToString());
resizer->RevertDrag();
}
{
window2_->SetBounds(gfx::Rect(121, 199, 10, 20));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTTOPRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("100,199 21x31", window_->bounds().ToString());
resizer->RevertDrag();
}
}
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_RIGHT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->SetBounds(gfx::Rect(121, 199, 10, 20));
window2_->Show();
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("100,200 21x30", window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_BOTTOMRIGHT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->Show();
{
window2_->SetBounds(gfx::Rect(122, 212, 10, 20));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("100,200 22x32", window_->bounds().ToString());
resizer->RevertDrag();
}
{
window2_->SetBounds(gfx::Rect(111, 233, 10, 20));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("100,200 21x33", window_->bounds().ToString());
resizer->RevertDrag();
}
}
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_BOTTOM) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->SetBounds(gfx::Rect(111, 233, 10, 20));
window2_->Show();
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOM));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("100,200 20x33", window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_BOTTOMLEFT) {
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->Show();
{
window2_->SetBounds(gfx::Rect(99, 231, 10, 20));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("99,200 21x31", window_->bounds().ToString());
resizer->RevertDrag();
}
{
window2_->SetBounds(gfx::Rect(89, 209, 10, 20));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("99,200 21x29", window_->bounds().ToString());
resizer->RevertDrag();
}
}
TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_LEFT) {
window2_->SetBounds(gfx::Rect(89, 209, 10, 20));
window_->SetBounds(gfx::Rect(100, 200, 20, 30));
window2_->Show();
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTLEFT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 0, 0), 0);
EXPECT_EQ("99,200 21x30", window_->bounds().ToString());
}
// Test that the user moved window flag is getting properly set.
TEST_F(WorkspaceWindowResizerTest, CheckUserWindowManagedFlags) {
window_->SetBounds(gfx::Rect(0, 50, 400, 200));
window_->SetProperty(aura::client::kResizeBehaviorKey,
ui::mojom::kResizeBehaviorCanMaximize);
std::vector<aura::Window*> no_attached_windows;
// Check that an abort doesn't change anything.
{
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Move it 100 to the bottom.
resizer->Drag(CalculateDragPoint(*resizer, 0, 100), 0);
EXPECT_EQ("0,150 400x200", window_->bounds().ToString());
resizer->RevertDrag();
EXPECT_FALSE(wm::GetWindowState(window_.get())->bounds_changed_by_user());
}
// Check that a completed move / size does change the user coordinates.
{
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
ASSERT_TRUE(resizer.get());
// Move it 100 to the bottom.
resizer->Drag(CalculateDragPoint(*resizer, 0, 100), 0);
EXPECT_EQ("0,150 400x200", window_->bounds().ToString());
resizer->CompleteDrag();
EXPECT_TRUE(wm::GetWindowState(window_.get())->bounds_changed_by_user());
}
}
// Test that a window with a specified max size doesn't exceed it when dragged.
TEST_F(WorkspaceWindowResizerTest, TestMaxSizeEnforced) {
window_->SetBounds(gfx::Rect(0, 0, 400, 300));
delegate_.set_max_size(gfx::Size(401, 301));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMRIGHT));
resizer->Drag(CalculateDragPoint(*resizer, 2, 2), 0);
EXPECT_EQ(401, window_->bounds().width());
EXPECT_EQ(301, window_->bounds().height());
}
// Test that a window with a specified max width doesn't restrict its height.
TEST_F(WorkspaceWindowResizerTest, TestPartialMaxSizeEnforced) {
window_->SetBounds(gfx::Rect(0, 0, 400, 300));
delegate_.set_max_size(gfx::Size(401, 0));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTBOTTOMRIGHT));
resizer->Drag(CalculateDragPoint(*resizer, 2, 2), 0);
EXPECT_EQ(401, window_->bounds().width());
EXPECT_EQ(302, window_->bounds().height());
}
// Test that a window with a specified max size can't be snapped.
TEST_F(WorkspaceWindowResizerTest, PhantomSnapMaxSize) {
// Make the window snappable by making it resizable and maximizable.
window_->SetProperty(aura::client::kResizeBehaviorKey,
ui::mojom::kResizeBehaviorCanResize |
ui::mojom::kResizeBehaviorCanMaximize);
{
// With max size not set we get a phantom window controller for dragging off
// the right hand side.
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
EXPECT_FALSE(snap_phantom_window_controller());
resizer->Drag(CalculateDragPoint(*resizer, 801, 0), 0);
EXPECT_TRUE(snap_phantom_window_controller());
resizer->RevertDrag();
}
{
// With max size defined, we get no phantom window for snapping.
window_->SetBounds(gfx::Rect(0, 0, 400, 200));
delegate_.set_max_size(gfx::Size(400, 200));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
resizer->Drag(CalculateDragPoint(*resizer, 801, 0), 0);
EXPECT_FALSE(snap_phantom_window_controller());
resizer->RevertDrag();
}
{
// With max size defined, we get no phantom window for snapping.
window_->SetBounds(gfx::Rect(0, 0, 400, 200));
delegate_.set_max_size(gfx::Size(400, 200));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window_.get(), gfx::Point(), HTCAPTION));
resizer->Drag(CalculateDragPoint(*resizer, 801, 0), 0);
EXPECT_FALSE(snap_phantom_window_controller());
resizer->RevertDrag();
}
}
TEST_F(WorkspaceWindowResizerTest, DontRewardRightmostWindowForOverflows) {
UpdateDisplay("600x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Four 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(200, 100, 100, 100));
window3_->SetBounds(gfx::Rect(300, 100, 100, 100));
window4_->SetBounds(gfx::Rect(400, 100, 100, 100));
delegate2_.set_max_size(gfx::Size(101, 0));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
windows.push_back(window4_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 51 to the left, which should contract w1 and expand w2-4.
// w2 will hit its max size straight away, and in doing so will leave extra
// pixels that a naive implementation may award to the rightmost window. A
// fair implementation will give 25 pixels to each of the other windows.
resizer->Drag(CalculateDragPoint(*resizer, -51, 0), 0);
EXPECT_EQ("100,100 49x100", window_->bounds().ToString());
EXPECT_EQ("149,100 101x100", window2_->bounds().ToString());
EXPECT_EQ("250,100 125x100", window3_->bounds().ToString());
EXPECT_EQ("375,100 125x100", window4_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, DontExceedMaxWidth) {
UpdateDisplay("600x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Four 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(200, 100, 100, 100));
window3_->SetBounds(gfx::Rect(300, 100, 100, 100));
window4_->SetBounds(gfx::Rect(400, 100, 100, 100));
delegate2_.set_max_size(gfx::Size(101, 0));
delegate3_.set_max_size(gfx::Size(101, 0));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
windows.push_back(window4_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 52 to the left, which should contract w1 and expand w2-4.
resizer->Drag(CalculateDragPoint(*resizer, -52, 0), 0);
EXPECT_EQ("100,100 48x100", window_->bounds().ToString());
EXPECT_EQ("148,100 101x100", window2_->bounds().ToString());
EXPECT_EQ("249,100 101x100", window3_->bounds().ToString());
EXPECT_EQ("350,100 150x100", window4_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, DontExceedMaxHeight) {
UpdateDisplay("600x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Four 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(100, 200, 100, 100));
window3_->SetBounds(gfx::Rect(100, 300, 100, 100));
window4_->SetBounds(gfx::Rect(100, 400, 100, 100));
delegate2_.set_max_size(gfx::Size(0, 101));
delegate3_.set_max_size(gfx::Size(0, 101));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
windows.push_back(window4_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTBOTTOM,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 52 up, which should contract w1 and expand w2-4.
resizer->Drag(CalculateDragPoint(*resizer, 0, -52), 0);
EXPECT_EQ("100,100 100x48", window_->bounds().ToString());
EXPECT_EQ("100,148 100x101", window2_->bounds().ToString());
EXPECT_EQ("100,249 100x101", window3_->bounds().ToString());
EXPECT_EQ("100,350 100x150", window4_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, DontExceedMinHeight) {
UpdateDisplay("600x500");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Four 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(100, 200, 100, 100));
window3_->SetBounds(gfx::Rect(100, 300, 100, 100));
window4_->SetBounds(gfx::Rect(100, 400, 100, 100));
delegate2_.set_min_size(gfx::Size(0, 99));
delegate3_.set_min_size(gfx::Size(0, 99));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
windows.push_back(window4_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTBOTTOM,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 52 down, which should expand w1 and contract w2-4.
resizer->Drag(CalculateDragPoint(*resizer, 0, 52), 0);
EXPECT_EQ("100,100 100x152", window_->bounds().ToString());
EXPECT_EQ("100,252 100x99", window2_->bounds().ToString());
EXPECT_EQ("100,351 100x99", window3_->bounds().ToString());
EXPECT_EQ("100,450 100x50", window4_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, DontExpandRightmostPastMaxWidth) {
UpdateDisplay("600x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Three 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(200, 100, 100, 100));
window3_->SetBounds(gfx::Rect(300, 100, 100, 100));
delegate3_.set_max_size(gfx::Size(101, 0));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
windows.push_back(window4_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 51 to the left, which should contract w1 and expand w2-3.
resizer->Drag(CalculateDragPoint(*resizer, -51, 0), 0);
EXPECT_EQ("100,100 49x100", window_->bounds().ToString());
EXPECT_EQ("149,100 150x100", window2_->bounds().ToString());
EXPECT_EQ("299,100 101x100", window3_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, MoveAttachedWhenGrownToMaxSize) {
UpdateDisplay("600x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Three 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(200, 100, 100, 100));
window3_->SetBounds(gfx::Rect(300, 100, 100, 100));
delegate2_.set_max_size(gfx::Size(101, 0));
delegate3_.set_max_size(gfx::Size(101, 0));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
windows.push_back(window4_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 52 to the left, which should contract w1 and expand and move w2-3.
resizer->Drag(CalculateDragPoint(*resizer, -52, 0), 0);
EXPECT_EQ("100,100 48x100", window_->bounds().ToString());
EXPECT_EQ("148,100 101x100", window2_->bounds().ToString());
EXPECT_EQ("249,100 101x100", window3_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, MainWindowHonoursMaxWidth) {
UpdateDisplay("400x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Three 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(200, 100, 100, 100));
window3_->SetBounds(gfx::Rect(300, 100, 100, 100));
delegate_.set_max_size(gfx::Size(102, 0));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
windows.push_back(window4_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 50 to the right, which should expand w1 and contract w2-3, as they
// won't fit in the root window in their original sizes.
resizer->Drag(CalculateDragPoint(*resizer, 50, 0), 0);
EXPECT_EQ("100,100 102x100", window_->bounds().ToString());
EXPECT_EQ("202,100 99x100", window2_->bounds().ToString());
EXPECT_EQ("301,100 99x100", window3_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, MainWindowHonoursMinWidth) {
UpdateDisplay("400x800");
aura::Window* root = Shell::GetPrimaryRootWindow();
Shell::Get()->SetDisplayWorkAreaInsets(root, gfx::Insets());
// Three 100x100 windows flush against eachother, starting at 100,100.
window_->SetBounds(gfx::Rect(100, 100, 100, 100));
window2_->SetBounds(gfx::Rect(200, 100, 100, 100));
window3_->SetBounds(gfx::Rect(300, 100, 100, 100));
delegate_.set_min_size(gfx::Size(98, 0));
std::vector<aura::Window*> windows;
windows.push_back(window2_.get());
windows.push_back(window3_.get());
std::unique_ptr<WorkspaceWindowResizer> resizer(
CreateWorkspaceResizerForTest(window_.get(), gfx::Point(), HTRIGHT,
::wm::WINDOW_MOVE_SOURCE_MOUSE, windows));
ASSERT_TRUE(resizer.get());
// Move it 50 to the left, which should contract w1 and expand w2-3.
resizer->Drag(CalculateDragPoint(*resizer, -50, 0), 0);
EXPECT_EQ("100,100 98x100", window_->bounds().ToString());
EXPECT_EQ("198,100 101x100", window2_->bounds().ToString());
EXPECT_EQ("299,100 101x100", window3_->bounds().ToString());
}
// The following variants test that windows are resized correctly to the edges
// of the screen using touch, when touch point is off of the window border.
TEST_F(WorkspaceWindowResizerTest, TouchResizeToEdge_RIGHT) {
GetPrimaryShelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
InitTouchResizeWindow(gfx::Rect(100, 100, 600, kRootHeight - 200), HTRIGHT);
EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
touch_resize_window_.get());
// Drag out of the right border a bit and check if the border is aligned with
// the touch point.
generator.GestureScrollSequence(gfx::Point(715, kRootHeight / 2),
gfx::Point(725, kRootHeight / 2),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 100, 625, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
// Drag more, but stop before being snapped to the edge.
generator.GestureScrollSequence(gfx::Point(725, kRootHeight / 2),
gfx::Point(760, kRootHeight / 2),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 100, 660, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
// Drag even more to snap to the edge.
generator.GestureScrollSequence(gfx::Point(760, kRootHeight / 2),
gfx::Point(775, kRootHeight / 2),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 100, 700, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, TouchResizeToEdge_LEFT) {
GetPrimaryShelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
InitTouchResizeWindow(gfx::Rect(100, 100, 600, kRootHeight - 200), HTLEFT);
EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
touch_resize_window_.get());
// Drag out of the left border a bit and check if the border is aligned with
// the touch point.
generator.GestureScrollSequence(gfx::Point(85, kRootHeight / 2),
gfx::Point(75, kRootHeight / 2),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(75, 100, 625, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
// Drag more, but stop before being snapped to the edge.
generator.GestureScrollSequence(gfx::Point(75, kRootHeight / 2),
gfx::Point(40, kRootHeight / 2),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(40, 100, 660, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
// Drag even more to snap to the edge.
generator.GestureScrollSequence(gfx::Point(40, kRootHeight / 2),
gfx::Point(25, kRootHeight / 2),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(0, 100, 700, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, TouchResizeToEdge_TOP) {
GetPrimaryShelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
InitTouchResizeWindow(gfx::Rect(100, 100, 600, kRootHeight - 200), HTTOP);
EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
touch_resize_window_.get());
// Drag out of the top border a bit and check if the border is aligned with
// the touch point.
generator.GestureScrollSequence(gfx::Point(400, 85), gfx::Point(400, 75),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 75, 600, kRootHeight - 175).ToString(),
touch_resize_window_->bounds().ToString());
// Drag more, but stop before being snapped to the edge.
generator.GestureScrollSequence(gfx::Point(400, 75), gfx::Point(400, 40),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 40, 600, kRootHeight - 140).ToString(),
touch_resize_window_->bounds().ToString());
// Drag even more to snap to the edge.
generator.GestureScrollSequence(gfx::Point(400, 40), gfx::Point(400, 25),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 0, 600, kRootHeight - 100).ToString(),
touch_resize_window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, TouchResizeToEdge_BOTTOM) {
GetPrimaryShelf()->SetAutoHideBehavior(SHELF_AUTO_HIDE_ALWAYS_HIDDEN);
InitTouchResizeWindow(gfx::Rect(100, 100, 600, kRootHeight - 200), HTBOTTOM);
EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 200).ToString(),
touch_resize_window_->bounds().ToString());
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow(),
touch_resize_window_.get());
// Drag out of the bottom border a bit and check if the border is aligned with
// the touch point.
generator.GestureScrollSequence(gfx::Point(400, kRootHeight - 85),
gfx::Point(400, kRootHeight - 75),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 175).ToString(),
touch_resize_window_->bounds().ToString());
// Drag more, but stop before being snapped to the edge.
generator.GestureScrollSequence(gfx::Point(400, kRootHeight - 75),
gfx::Point(400, kRootHeight - 40),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 140).ToString(),
touch_resize_window_->bounds().ToString());
// Drag even more to snap to the edge.
generator.GestureScrollSequence(gfx::Point(400, kRootHeight - 40),
gfx::Point(400, kRootHeight - 25),
base::TimeDelta::FromMilliseconds(10), 5);
EXPECT_EQ(gfx::Rect(100, 100, 600, kRootHeight - 100).ToString(),
touch_resize_window_->bounds().ToString());
}
TEST_F(WorkspaceWindowResizerTest, PipCanBeResized) {
aura::Window* root_window = Shell::GetPrimaryRootWindow();
aura::Window* container =
Shell::GetContainer(root_window, kShellWindowId_AlwaysOnTopContainer);
std::unique_ptr<aura::Window> window(
aura::test::CreateTestWindowWithId(0, container));
window->SetBounds(gfx::Rect(20, 30, 50, 60));
window->Show();
auto* fake_state = new FakeWindowState(mojom::WindowStateType::PIP);
wm::WindowState* window_state = wm::GetWindowState(window.get());
window_state->SetStateObject(
std::unique_ptr<wm::WindowState::State>(fake_state));
std::unique_ptr<WindowResizer> resizer(
CreateResizerForTest(window.get(), gfx::Point(), HTRIGHT));
ASSERT_TRUE(resizer.get());
resizer->Drag(CalculateDragPoint(*resizer, 50, 0), 0);
resizer->CompleteDrag();
EXPECT_EQ("20,30 100x60", fake_state->last_bounds().ToString());
}
} // namespace ash