commit | b0eab4a3e36612417196e6766d7a770f675169c4 | [log] [tgz] |
---|---|---|
author | Stephen McGruer <smcgruer@chromium.org> | Wed Jan 09 17:27:20 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 09 17:27:20 2019 |
tree | 8d8a68d1b29f670831e1a735eef89b15b2a810df | |
parent | fbcd25f1d9a037e648e951e04fe7f8c4515620d7 [diff] |
[BlinkGenPropertyTrees] Fix ElementIsAnimatingChanged logic As of https://crrev.com/2a64f7b5, there is no longer a single ElementId for an entire 'animating target' in cc. However ElementIsAnimatingChanged still assumes that it can lookup the different types of nodes (TransformNode, EffectNode) using a single ElementId. This caused both incorrect logic (code that should have been executed was not as the node could not be found) as well as DCHECK failures (again from the incorrect branch). This fix is essentially a hack, and it is important to note that we don't have a clear idea of what ElementIsAnimatingChanged is required for (i.e. what the consequences of it not working -outside of DCHECKs - are). The goal of this CL is just to restore the function to how it was working before https://crrev.com/2a64f7b5. Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0d0eb0c9add83ff3c1b6d6f30858804aed300aac Bug: 912574 Reviewed-on: https://chromium-review.googlesource.com/c/1372173 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#621198}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .