commit | b15c7718399539b459276cefcd72c91684e506ac | [log] [tgz] |
---|---|---|
author | Owen Rodley <orodley@chromium.org> | Thu Mar 25 04:25:47 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 25 04:25:47 2021 |
tree | da50c2d6bf2f36c871dd090a15b776686e8ccb13 | |
parent | 57342c1fca3feb8774fe9ea8e4a439278c432155 [diff] |
Only apply 'force_build' to the requested packages. Currently to_build and force_build don't combine very well - if you want to force (for example) cpython or git to build, passing force_build will also force it to build all their dependencies, of which there are dozens, which means you have to wait a long time before it builds the package you actually care about. After this change, force_build only applies to the set of packages explicitly listed via to_build. This shouldn't have any production impact, as force_build isn't used in prod. Change-Id: I53909ed3283b3a90159c71b0887539ccd717e572 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2784170 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#39711}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.