Google Git
Sign in
chromium / chromium / src / b1699100facc4616a97e1f190cee0fc333d20c27
commitb1699100facc4616a97e1f190cee0fc333d20c27[log] [tgz]
authorTom Anderson <thomasanderson@chromium.org>Fri Aug 25 17:38:11 2017
committerCommit Bot <commit-bot@chromium.org>Fri Aug 25 17:38:11 2017
treedf58a7fbb27b729cd49a2f323cae88dc109db9d4
parentd0b64982cedc3571cb97b1c61da7f41e3bf9890c [diff]
Gtk: Explicitly track if nav buttons are set in GtkUi

GtkUi used to implicitly track if the nav button layout was set by
checking if the button layout was nonempty.  This caused a bug where
the button layout would incorrectly display the default button layout
(minimize, maximize, and close all on the right) when Chrome was
launched and the GTK setting had no frame buttons.

Note that it was still possible to get Chrome to display no frame
buttons if you changed the GTK setting after Chrome was launched.

BUG=21438
R=erg@chromium.org

Change-Id: Ie9f9f4d72b2009b600f50eda4c647dc20e2d5196
Reviewed-on: https://chromium-review.googlesource.com/633837
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497456}
2 files changed
tree: df58a7fbb27b729cd49a2f323cae88dc109db9d4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .