commit | b16a5e5369333aba4966cf3be5272af25d66f3dd | [log] [tgz] |
---|---|---|
author | A Olsen <olsen@chromium.org> | Fri Sep 21 15:48:46 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Sep 21 15:48:46 2018 |
tree | 23cda4214ad922f19182da9096a016da253f5aef | |
parent | 2ab0fae22e92732423600bf24b1263ec9afea6e1 [diff] |
Remove BrowserProcess dep in c/b/chromeos/settings DeviceSettingsProvider in chrome/browser/chromeos/settings has an undesirable dependency on g_browser_process, which it uses to access the LocalState singleton. This CL removes the dependency on g_browser_process by passing in LocalState explicitly. Note that the tests and test helpers still depend on BrowserProcess or TestingBrowserProcess, which they use to initialize and access the LocalState. For tests in the settings package, I need to find a way to remove this dependency in a follow up CL, so that the settings package along with tests & test helpers can be moved out of chrome/browser. See go/cros-untangle2 Bug: 446937 Change-Id: If9b14940f05ceef1fa8f33e612df22d3d9173d8f Reviewed-on: https://chromium-review.googlesource.com/1233711 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593199}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .