Google Git
Sign in
chromium / chromium / src / b24da2a239e0587a01b769c3e5a18ddefd07d1b7
commitb24da2a239e0587a01b769c3e5a18ddefd07d1b7[log] [tgz]
authorMarc Treib <treib@chromium.org>Tue Jan 16 09:44:26 2018
committerCommit Bot <commit-bot@chromium.org>Tue Jan 16 09:44:26 2018
treec30629606f5e71cf11c9723048dba06060f8e980
parent2ce1fe0f2b58d9eeb7d2bf78d988f618b56d31e9 [diff]
[Mac] Use SRGB color space when converting from SkColor to CGColor

This fixes flashes when opening themed or incognito NTPs:
TabContentsController::updateBackgroundColorFromWindowTheme uses
skia::CGColorCreateFromSkColor to convert the background color from
SkColor to CGColor, which used the "Generic RGB" color space before.
This does not match SRGB, which is what the NTP (or any WebContents)
uses, as far as I can tell.
This CL fixes the discrepancy by making CGColorCreateFromSkColor use
SRGB.

Bug: 21798, 254361, 719236
Change-Id: I14b03690f585d266b6329d6b19b37ee8ac36c6ce
Reviewed-on: https://chromium-review.googlesource.com/842646
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529390}
2 files changed
tree: c30629606f5e71cf11c9723048dba06060f8e980
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .