| commit | b253f7d956eaea3f0d18993561e51134d4619b6f | [log] [tgz] |
|---|---|---|
| author | Gavin Mak <gavinmak@google.com> | Fri Oct 16 18:02:26 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Oct 16 18:02:26 2020 |
| tree | e456b5c79e116414b43e21f87a9e3e024b5631f8 | |
| parent | caa3032972719e306cfba1842894e2eee18c3eab [diff] |
Change read mode from rU to rb package_index.py uses the universal newlines mode 'U' in reading files, which is deprecated. This mode also leads to modified files, e.g. missing carriage returns. Bug:873956 Change-Id: I798facc91dc797feb3434a70ed72d4222d782d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2469037 Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format --no-clang-format) to autoformat new code.