commit | b28709c2c9152a798564e29b67f977f8a60512f8 | [log] [tgz] |
---|---|---|
author | Bence Béky <bnc@chromium.org> | Tue Mar 06 13:03:44 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Mar 06 13:03:44 2018 |
tree | 67b02aa7851b34f271a67320f5e773327ee55f06 | |
parent | 166d4288e48a0435c5aba1f3ba0d7bd0c7198487 [diff] |
Refactor WebSocket handshake helpers into base class. Refactor helper functions shared by WebSocketBasicHandshakeStream and WebSocketHttp2HandshakeStream from anonymous namespace into WebSocketHandshakeStreamBase as static methods, protected if only used by derived classes, public if used by other helper functions remaining in anonymous namespace. Also remove out-of-line WebSocketHandshakeStreamBase constructor and destructor and remove obsolete comment, as WebSocket is not compiled on iOS. Also remove kSecWebSocketProtocolLowercase and kSecWebSocketExtensionsLowercase. There is no need for these because HttpResponseHeaders::EnumerateHeader() is case-insensitive. This is a follow-up to https://crrev.com/c/926769/2/net/websockets/websocket_http2_handshake_stream.cc#61 Bug: 801564 Change-Id: I0afdc5c66f743af4df8a1b7151b40e7a8e08e8bd Reviewed-on: https://chromium-review.googlesource.com/949282 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#541084}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .